Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[net8] Fix ILLink for net8 remote builds #17600

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[net8] Fix ILLink for net8 remote builds #17600

merged 1 commit into from
Feb 24, 2023

Conversation

mauroa
Copy link
Contributor

@mauroa mauroa commented Feb 23, 2023

From net8, ILLink is not part of dotnet/sdk anymore but part of dotnet/runtime: https://github.com/dotnet/runtime/tree/main/src/tools/illink/src/ILLink.Tasks

This means that now it's a NuGet package called Microsoft.NET.ILLink.Tasks and it's installed as part of the dotnet SDK installation

This affects the remote builds since we were looking on the dotnet SDK installation folder used by XMA (/Library/Caches/Xamarin/XMA/SDKs/dotnet) to find the 'illink.dll' assembly, but now that file is located in the NuGet packages folder used by XMA (/Library/Caches/Xamarin/XMA/SDKs/.home).

This change consists of adding some new MSBuild properties to calculate the right path of the 'illink.dll' assembly depending on if it's included in the SDK or not

This should fix Bug #1748997 - [XVS][.NET 8] Build failed with two errors when Target Framework is net8.0-ios: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1748997

@mauroa
[net8] Fix ILLink for net8 remote builds
c769e7e 
ILLink is not part of dotnet/sdk anymore but part of dotnet/runtime: https://github.com/dotnet/runtime/tree/main/src/tools/illink/src/ILLink.Tasks

This means that now it's a NuGet package called `Microsoft.NET.ILLink.Tasks` and it's installed as part of the dotnet SDK installation

This affects the remote builds since we were looking on the dotnet SDK installation folder used by XMA (~/Library/Caches/Xamarin/XMA/SDKs/dotnet) to find the 'illink.dll' assembly, but now that file is located in the NuGet packages folder used by XMA (~/Library/Caches/Xamarin/XMA/SDKs/.home).

This change consists of adding some new MSBuild properties to calculate the right path of the 'illink.dll' assembly using the '.home' folder that is used exclusively by XMA as a cache for dotnet SDK installation purposes

This should fix Bug #1748997 - [XVS][.NET 8] Build failed with two errors when Target Framework is net8.0-ios: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1748997
@mauroa mauroa self-assigned this Feb 23, 2023
@mauroa mauroa added the not-notes-worthy Ignore for release notes label Feb 23, 2023
@mauroa mauroa mentioned this pull request Feb 23, 2023
Closed
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c769e7ec5c652a51ce3786f8bd0a6ae621638e50 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: c769e7ec5c652a51ce3786f8bd0a6ae621638e50 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: c769e7ec5c652a51ce3786f8bd0a6ae621638e50 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1044.Monterey'
Hash: c769e7ec5c652a51ce3786f8bd0a6ae621638e50 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 218 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
  • [xUnit] Mono SystemCoreXunit Part 1/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c769e7ec5c652a51ce3786f8bd0a6ae621638e50 [PR build]

@mauroa
Copy link
Contributor Author

mauroa commented Feb 23, 2023

@rolfbjarne should we backport to release/8.0.1xx-preview1 as well?

@rolfbjarne
Copy link
Member

@rolfbjarne should we backport to release/8.0.1xx-preview1 as well?

I'm not sure if we'll release any updates to P1, but I can backport and then we'll see what happens.

@rolfbjarne
Copy link
Member

/sudo backport release/8.0.1xx-preview1

@rolfbjarne
Copy link
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-preview1 Created! The magic is happening here

@rolfbjarne rolfbjarne merged commit b37c043 into net8.0 Feb 24, 2023
@rolfbjarne rolfbjarne deleted the dev/mag/net8.0 branch February 24, 2023 12:54
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7379476 for more details.

rolfbjarne pushed a commit that referenced this pull request Feb 27, 2023
@vs-mobiletools-engineering-service2 @mauroa
[release/8.0.1xx-preview1] [net8] Fix ILLink for net8 remote builds (#…
57bf478 
…17619)

From net8, ILLink is not part of dotnet/sdk anymore but part of dotnet/runtime: https://github.com/dotnet/runtime/tree/main/src/tools/illink/src/ILLink.Tasks

This means that now it's a NuGet package called `Microsoft.NET.ILLink.Tasks` and it's installed as part of the dotnet SDK installation

This affects the remote builds since we were looking on the dotnet SDK installation folder used by XMA (/Library/Caches/Xamarin/XMA/SDKs/dotnet) to find the 'illink.dll' assembly, but now that file is located in the NuGet packages folder used by XMA (/Library/Caches/Xamarin/XMA/SDKs/.home).

This change consists of adding some new MSBuild properties to calculate the right path of the 'illink.dll' assembly depending on if it's included in the SDK or not

This should fix Bug #1748997 - [XVS][.NET 8] Build failed with two errors when Target Framework is net8.0-ios: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1748997


Backport of #17600

Co-authored-by: Mauro Agnoletti <[email protected]>
@rolfbjarne rolfbjarne mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

Assignees

@mauroa mauroa

Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauroa @vs-mobiletools-engineering-service2 @rolfbjarne @mandel-macaque