[NearbyInteraction] Remove NISession.SetARSession from Mac Catalyst. #17300
Conversation
ARKit is in a weird spot on Mac Catalyst: it exists, but it doesn't do anything. Since it doesn't actually work, we don't have bindings for ARKit. This means that while the method '[NISession setARSession:]' technically exists on Mac Catalyst, we can't bind it properly, since the type of the parameter (ARSession) isn't available in our bindings for Mac Catalyst. Due to how we hack around the lack of ARSession in our source code, we ended up binding the method with an NSObject argument instead. This is still wrong, so here I'm removing that method from the API. But of course, removing that API is a breaking change, so until then the method is obsoleted and hidden, and only removed in XAMCORE_5_0. Also hide a few other obsoleted API in NISession, and remove those as well in XAMCORE_5_0.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
.NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 224 tests passed. Failures❌ bcl tests [attempt 2]
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2620). |
…17300) ARKit is in a weird spot on Mac Catalyst: it exists, but it doesn't do anything. Since it doesn't actually work, we don't have bindings for ARKit. This means that while the method '[NISession setARSession:]' technically exists on Mac Catalyst, we can't bind it properly, since the type of the parameter (ARSession) isn't available in our bindings for Mac Catalyst. Due to how we hack around the lack of ARSession in our source code, we ended up binding the method with an NSObject argument instead. This is still wrong, so here I'm removing that method from the API. But of course, removing that API is a breaking change, so until then the method is obsoleted and hidden, and only removed in XAMCORE_5_0. Also hide a few other obsoleted API in NISession, and remove those as well in XAMCORE_5_0.
ARKit is in a weird spot on Mac Catalyst: it exists, but it doesn't do
anything. Since it doesn't actually work, we don't have bindings for ARKit.
This means that while the method '[NISession setARSession:]' technically
exists on Mac Catalyst, we can't bind it properly, since the type of the
parameter (ARSession) isn't available in our bindings for Mac Catalyst.
Due to how we hack around the lack of ARSession in our source code, we ended
up binding the method with an NSObject argument instead. This is still wrong,
so here I'm removing that method from the API.
But of course, removing that API is a breaking change, so until then the
method is obsoleted and hidden, and only removed in XAMCORE_5_0.
Also hide a few other obsoleted API in NISession, and remove those as well in
XAMCORE_5_0.