-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[generator] Fix an issue with regards to attributes from inlined protocols. Fixes #17268. #17269
[generator] Fix an issue with regards to attributes from inlined protocols. Fixes #17268. #17269
Conversation
…ocols. Fixes xamarin#17268. In the following scenario: * Type T is not available on a platform (say tvOS). * Protocol P is available on said platform. * A member M of P has its own availability attribute for said platform (for instance if P is available on tvOS 11.0, and the member is available on tvOS 12.0). * The protocol P is inlined into the type T. We'd include the SupportedOSPlatform attribute from the inlined member on generated code on other platforms (so the iOS assembly would say that the inlined member M in T is available on tvOS). Fixes xamarin#17268.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
…ocols. Fixes xamarin#17268. (xamarin#17269) In the following scenario: * Type T is not available on a platform (say tvOS). * Protocol P is available on said platform. * A member M of P has its own availability attribute for said platform (for instance if P is available on tvOS 11.0, and the member is available on tvOS 12.0). * The protocol P is inlined into the type T. We'd include the SupportedOSPlatform attribute from the inlined member on generated code on other platforms (so the iOS assembly would say that the inlined member M in T is available on tvOS). Fixes xamarin#17268.
In the following scenario:
instance if P is available on tvOS 11.0, and the member is available on tvOS
12.0).
We'd include the SupportedOSPlatform attribute from the inlined member on
generated code on other platforms (so the iOS assembly would say that the
inlined member M in T is available on tvOS).
Fixes #17268.