Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreMotion] Added support for Xcode 14.1 b1 #16118

Merged
merged 5 commits into from
Oct 7, 2022
Merged

[CoreMotion] Added support for Xcode 14.1 b1 #16118

merged 5 commits into from
Oct 7, 2022

Conversation

SotoiGhost
Copy link
Contributor

No description provided.

@SotoiGhost SotoiGhost added the notes-mention Deserves a mention in release notes label Sep 23, 2022
@SotoiGhost SotoiGhost added this to the xcode14.1 milestone Sep 23, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
tj-devel709
tj-devel709 reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nit things.
I also started this one, but closed it due to being on the incorrect branch and having conflicts. It did not include the 14.1 b1 changes though and can be found here: https://github.com/xamarin/xamarin-macios/pull/15977/files#diff-d27d21346ea9e21416f16996de088338485c706566c16100166f6f5d2f55d5af.
I think you'll want to add this line in as well though
https://github.com/xamarin/xamarin-macios/pull/15977/files#diff-d27d21346ea9e21416f16996de088338485c706566c16100166f6f5d2f55d5afR842

src/coremotion.cs Outdated Show resolved Hide resolved
src/coremotion.cs Outdated Show resolved Hide resolved
@mandel-macaque mandel-macaque marked this pull request as ready for review October 3, 2022 16:07
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne approved these changes Oct 4, 2022
View reviewed changes
src/coremotion.cs
@@ -859,4 +859,118 @@ interface CMRecordedPressureData {
NSDate StartDate { get; }
}

[NoMac, NoiOS, NoMacCatalyst, Watch (9,0), NoTV]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

Suggested change
[NoMac, NoiOS, NoMacCatalyst, Watch (9,0), NoTV]
[NoMac, NoiOS, NoMacCatalyst, Watch (9,1), NoTV]

and the same for the other ones below?

Copy link
Contributor Author

@SotoiGhost SotoiGhost Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers say that these clases are supported on 9.0. Should we bump the version anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's fine

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS: vsdrops gist (No breaking changes)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d4c1d829dfcbb9a4bc3114e18d47cc5fbf7c4e84 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1179.Monterey'
Hash: d4c1d829dfcbb9a4bc3114e18d47cc5fbf7c4e84 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • linkall
  • monotouch-test

Pipeline on Agent
Hash: d4c1d829dfcbb9a4bc3114e18d47cc5fbf7c4e84 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 7 tests failed, 162 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

2 tests failed, 63 tests passed.
  • trimmode copy/iOS Unified 64-bits - simulator/Debug [dotnet]: LaunchTimedOut
  • link sdk/iOS Unified 64-bits - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

3 tests failed, 20 tests passed.
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: LaunchTimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): LaunchTimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): LaunchTimedOut

Html Report (VSDrops) Download

❌ mtouch tests

1 tests failed, 0 tests passed.
  • MTouch tests/NUnit: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ bcl: All 10 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@mandel-macaque
Copy link
Member

Failures are unrelated.

@mandel-macaque mandel-macaque merged commit b97e797 into xamarin:xcode14.1 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tj-devel709 tj-devel709 tj-devel709 left review comments

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees
No one assigned
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Milestone
xcode14.1
Development

Successfully merging this pull request may close these issues.
5 participants
@SotoiGhost @vs-mobiletools-engineering-service2 @mandel-macaque @rolfbjarne @tj-devel709