Merge main into xcode14. #15950
Merged
Merge main into xcode14. #15950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5919) I always have to look through all the namespaces to figure out where a specific test is, so this simplifies things a bit. It's also where the tasks themselves are headed at some point.
…eCallback] Partial Fix for xamarin#10470 (xamarin#15906) Completed the work for CoreGraphics. One exception is PDFArray.cs which uses `SetupBlockUnsafe` (noted in the issue) Co-authored-by: Manuel de la Pena <[email protected]>
xamarin#15931) Only install the XI and/or XM package if the corresponding part of the build is enabled. Also don't install either if the legacy Xamarin build is disabled.
…enabled. (xamarin#15930) * Move the bash in the yml file to a separate script file to ease reading, writing & debugging. * Don't install any symlinks if legacy Xamarin isn't enabled. * Only install the iOS / macOS symlink if the corresponding build is enabled.
The mini tests were removed [eons][1] ago, so remove the remaining file as well. [1]: xamarin@c4a8949
…titlements. (xamarin#15918) This is the behavior in legacy Xamarin (for mobile projects): if a project contains a CodesignEntitlements=Entitlements.plist property, we require a provisioning profile (and failing the build if none is found). In .NET, the expected behavior is that if a file is in the project directory, it should be detected automatically and handled accordingly. We didn't do this for the initial release of .NET, but we implemented it later (xamarin#15729). However, this turned out to be complicated, because many templates provide an Entitlements.plist file, and now suddenly just the presence of such a file would require a provisioning profile, which also means setting up the whole rigmarole of Apple's certificates and provisioning profiles (and even potentially getting a paid Apple Developer account). This usually worked well in legacy Xamarin, because in templates only the Release configuration would set the CodesignEntitlements=Entitlements.plist property, and thus we'd only require a provisioning profile for release builds (and the Entitlements.plist file would be ignored for Debug builds). Here we change the default behavior when building for .NET so that we only require a provisioning profile if the Entitlements.plist file is empty (i.e. doesn't request any entitlements). I've also implemented an override, where setting the CodesignRequireProvisioningProfile=true property will override our default logic. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1613459.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
approved these changes
Sep 13, 2022
tj-devel709
approved these changes
Sep 13, 2022
chamons
approved these changes
Sep 13, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 17 tests failed, 211 tests passed. Failures❌ bcl tests
Html Report (VSDrops) Download ❌ framework tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ monotouch tests
Html Report (VSDrops) Download ❌ xtro tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failrues are unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.