Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeviceDiscoveryUI] Added support for Xcode 14 b1 #15762

Closed
wants to merge 6 commits into from
Closed

[DeviceDiscoveryUI] Added support for Xcode 14 b1 #15762

wants to merge 6 commits into from

Conversation

SotoiGhost
Copy link
Contributor

No description provided.

@SotoiGhost SotoiGhost added the notes-mention Deserves a mention in release notes label Aug 24, 2022
@SotoiGhost SotoiGhost added this to the xcode14 milestone Aug 24, 2022
tj-devel709
tj-devel709 requested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions!

src/DeviceDiscoveryUI/DDDevicePickerViewController.cs Outdated Show resolved Hide resolved
src/DeviceDiscoveryUI/DDDevicePickerViewController.cs Outdated Show resolved Hide resolved
src/DeviceDiscoveryUI/DDDevicePickerViewController.cs Outdated Show resolved Hide resolved
src/DeviceDiscoveryUI/DDDevicePickerViewController.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a rule regarding manually written binding code: all such code must have manual tests as well.

Experience has taught us that without tests we get the bindings more often wrong than not.

src/DeviceDiscoveryUI/DDDevicePickerViewController.cs Outdated Show resolved Hide resolved
src/DeviceDiscoveryUI/DDDevicePickerViewController.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@SotoiGhost
Copy link
Contributor Author

This framework needs some new methods defined within the Network framework. This is blocked by now.

@SotoiGhost SotoiGhost changed the title [DeviceDiscoveryUI] Added support for Xcode 14 b1 [do-not-merge][DeviceDiscoveryUI] Added support for Xcode 14 b1 Aug 27, 2022
@mandel-macaque
Copy link
Member

@SotoiGhost I'll take care of Network

@SotoiGhost
Copy link
Contributor Author

@mandel-macaque if there is a complex work to be done, I can handle Network if you want

@mandel-macaque
Copy link
Member

@SotoiGhost the network PR is here: #15841 should be landed once the tests pass.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@SotoiGhost SotoiGhost changed the title [do-not-merge][DeviceDiscoveryUI] Added support for Xcode 14 b1 [DeviceDiscoveryUI] Added support for Xcode 14 b1 Sep 9, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 5510de1c3562144b1f71cb1480cc46f33e4aeb7e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS: vsdrops gist (No breaking changes)
  • watchOS (no change detected)
  • macOS (no change detected)
.NET (No breaking changes)
  • iOS: (empty diff detected)
  • tvOS: vsdrops gist (No breaking changes)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5510de1c3562144b1f71cb1480cc46f33e4aeb7e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1168.Monterey'
Hash: 5510de1c3562144b1f71cb1480cc46f33e4aeb7e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 5510de1c3562144b1f71cb1480cc46f33e4aeb7e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 16 tests failed, 212 tests passed.

Failures

❌ fsharp tests

1 tests failed, 6 tests passed.
  • fsharp/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

❌ framework tests

1 tests failed, 7 tests passed.
  • framework-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ monotouch tests

12 tests failed, 11 tests passed.
  • monotouch-test/tvOS - simulator/Debug [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

❌ xtro tests

1 tests failed, 1 tests passed.
  • Xtro/Legacy Xamarin: Failed (Test run failed.)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

chamons
chamons reviewed Oct 4, 2022
View reviewed changes
src/DeviceDiscoveryUI/DDDevicePickerViewController.cs
public static bool IsSupported (NWBrowserDescriptor browseDescriptor, NWParameters? parameters) =>
_IsSupported (browseDescriptor.GetNonNullHandle (nameof (browseDescriptor)), parameters.GetHandle ());

[Advice ("Verify if this controller is supported by calling DDDevicePickerViewController.IsSupported before creating an instance, as this will crash if not supported.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs should not have Advice still in them.

@rolfbjarne rolfbjarne removed this from the xcode14 milestone Jan 10, 2023
@rolfbjarne
Copy link
Member

Closing in favor of #20271.

@rolfbjarne rolfbjarne closed this Mar 6, 2024
@rolfbjarne rolfbjarne mentioned this pull request Mar 7, 2024
Merged
rolfbjarne added a commit that referenced this pull request Mar 8, 2024
@rolfbjarne
[DeviceDiscoveryUI] Added bindings for DeviceDiscoveryUI. (#20271)
58e382e 
Follow-up of #15762.

---------

Co-authored-by: Israel Soto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chamons chamons chamons left review comments

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SotoiGhost @vs-mobiletools-engineering-service2 @mandel-macaque @rolfbjarne @chamons @tj-devel709