[msbuild] Use the full path to the symbols list file. Fixes #15046. #15105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Give the full path to the symbols list file in the extension project to the main project, so that strip can find it. When building a solution remotely from Windows, we can't compute a relative path between projects, because they're laid out differently on disk. This means that we have to use full paths when passing paths between projects (such as the path to the symbol list file). Fixes dotnet#15046.
dalexsoto
approved these changes
May 24, 2022
emaf
approved these changes
May 24, 2022
tj-devel709
approved these changes
May 24, 2022
chamons
approved these changes
May 24, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
approved these changes
May 24, 2022
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as outdated.
This comment was marked as outdated.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1105.Monterey |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results4 tests failed, 144 tests passed.Failed tests
Pipeline on Agent XAMBOT-1017.Monterey' |
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2558). |
|
/sudo backport d17-2 |
|
Backport Job to branch d17-2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6311223 for more details. |
rolfbjarne
added a commit
that referenced
this pull request
Jun 27, 2022
…15046. (#15307) Give the full path to the symbols list file in the extension project to the main project, so that strip can find it. When building a solution remotely from Windows, we can't compute a relative path between projects, because they're laid out differently on disk. This means that we have to use full paths when passing paths between projects (such as the path to the symbol list file). Fixes #15046. Backport of #15105 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the full path to the symbols list file in the extension project to the
main project, so that strip can find it.
When building a solution remotely from Windows, we can't compute a relative
path between projects, because they're laid out differently on disk. This
means that we have to use full paths when passing paths between projects (such
as the path to the symbol list file).
Fixes #15046.