[d17-2] [msbuild] Use the full path to the symbols list file. Fixes #15046. #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Give the full path to the symbols list file in the extension project to the main project, so that strip can find it. When building a solution remotely from Windows, we can't compute a relative path between projects, because they're laid out differently on disk. This means that we have to use full paths when passing paths between projects (such as the path to the symbol list file). Fixes dotnet#15046.
vs-mobiletools-engineering-service2
requested review from
emaf,
mauroa,
rolfbjarne and
chamons
as code owners
vs-mobiletools-engineering-service2
added
backported
bug
|
This PR needs #15309 to be merged first to get some build fixes. |
dalexsoto
approved these changes
Jun 21, 2022
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results2 tests failed, 147 tests passed.Failed tests
Pipeline on Agent XAMBOT-1107.Monterey' |
|
Test failures are unrelated:
|
rolfbjarne
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the full path to the symbols list file in the extension project to the
main project, so that strip can find it.
When building a solution remotely from Windows, we can't compute a relative
path between projects, because they're laid out differently on disk. This
means that we have to use full paths when passing paths between projects (such
as the path to the symbol list file).
Fixes #15046.
Backport of #15105