Bump maccore to get fix for #14834. #14946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commits in xamarin/maccore: * xamarin/maccore@29a1c1382e [mlaunch] Redirect stdout and stderr through a pty when launching in the simulator. Fixes xamarin#14834. Diff: https://github.com/xamarin/maccore/compare/749e84cb162b945dafa85fd6dffe80a727a491cf..29a1c1382e005e568b57d1b45e3877c8081dfc8b Fixes xamarin/maccore#2575.
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
May 9, 2022
tj-devel709
approved these changes
May 9, 2022
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1164.Monterey' |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1166.Monterey' |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
|
/sudo backport d17-2 |
dalexsoto
approved these changes
May 9, 2022
|
Backport Job to branch d17-2 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6127928 for more details. |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
May 9, 2022
New commits in xamarin/maccore: * xamarin/maccore@29a1c1382e [mlaunch] Redirect stdout and stderr through a pty when launching in the simulator. Fixes xamarin#14834. * xamarin/maccore@749e84cb16 [mlaunch] Make minor improvements to Main.cs Diff: https://github.com/xamarin/maccore/compare/cf9f7409e9a79d0d0835863cc9f5afe77ba5e74a..29a1c1382e005e568b57d1b45e3877c8081dfc8b Fixes xamarin#14834. Backport of xamarin#14946.
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results20 tests failed, 126 tests passed.Failed tests
Pipeline on Agent XAMBOT-1033.Monterey' |
rolfbjarne
added a commit
that referenced
this pull request
May 10, 2022
New commits in xamarin/maccore: * xamarin/maccore@29a1c1382e [mlaunch] Redirect stdout and stderr through a pty when launching in the simulator. Fixes #14834. * xamarin/maccore@749e84cb16 [mlaunch] Make minor improvements to Main.cs Diff: https://github.com/xamarin/maccore/compare/cf9f7409e9a79d0d0835863cc9f5afe77ba5e74a..29a1c1382e005e568b57d1b45e3877c8081dfc8b Fixes #14834. Backport of #14946.
rolfbjarne
added a commit
that referenced
this pull request
May 10, 2022
New commits in xamarin/maccore: * xamarin/maccore@b457f4bdee [xcode13.3] [mlaunch] Redirect stdout and stderr through a pty when launching in the simulator. Fixes #14834. Diff: https://github.com/xamarin/maccore/compare/59583606121bcc15bad6580f3b0ee6ced8d0bdeb..b457f4bdee9138998a3e875bfbca6993f73a47ff Fixes #14834. Backport of #14946.
|
Test failures are all network related (https://github.com/xamarin/maccore/issues/1067). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commits in xamarin/maccore:
Diff: https://github.com/xamarin/maccore/compare/749e84cb162b945dafa85fd6dffe80a727a491cf..29a1c1382e005e568b57d1b45e3877c8081dfc8b
Fixes #14834.