[d17-2] [Foundation] Ensure that post requests are not cached by the native code. #14739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode. The behaviour from apple is wrong, PUT and POST are differnet in that PUT is idempotent. Calling PUT several times successively has the same effect (that is no side effect), where successive identical POST may have additional effects We should not let the native code cache the calls.
vs-mobiletools-engineering-service2
requested a review
from mandel-macaque
as a code owner
vs-mobiletools-engineering-service2
added
backported
bug
mandel-macaque
approved these changes
Apr 13, 2022
dalexsoto
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour from apple is wrong, PUT and POST are differnet in that PUT is idempotent.
Calling PUT several times successively has the same effect (that is no side effect),
where successive identical POST may have additional effects
We should not let the native code cache the calls.
Related issue: https://github.com/xamarin/maccore/issues/2571
Backport of #14729