Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assetslibrary] Add nullability to (generated and manual) bindings #14222

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

tj-devel709
Copy link
Contributor

This PR aims to bring nullability changes to AssetsLibrary.
Following the steps here:

  1. Changing any == null or != null to is null and is not null
    • In this case, use updated features to replace "== null"

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label Feb 22, 2022
@tj-devel709 tj-devel709 added this to the Future milestone Feb 22, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 107 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2708 Passed: 2514 Inconclusive: 11 Failed: 2 Ignored: 192)

Pipeline on Agent XAMBOT-1103.BigSur'
Merge 6ce47be into 868dad9

@tj-devel709
Copy link
Contributor Author

Unrelated Test Failure

@tj-devel709 tj-devel709 merged commit b2cc6d9 into xamarin:main Feb 23, 2022
tj-devel709 added a commit to tj-devel709/xamarin-macios that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants