[.NET/Security] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] for the managed callbacks called from native code. #13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lback] for the managed callbacks called from native code. Ref xamarin#10470.
Therzok
reviewed
Nov 5, 2021
| { | ||
| var c = (SslConnection) GCHandle.FromIntPtr (connection).Target; | ||
| return c.Read (data, ref dataLength); | ||
| return c.Read (data, ref System.Runtime.CompilerServices.Unsafe.AsRef<nint> (dataLength)); |
There was a problem hiding this comment.
Why the unsafe pointer here? It's possible to use ref nint in the signature.
There was a problem hiding this comment.
@Therzok no, it's not possible to use ref nint in the signature, because it's not blittable: dotnet/roslyn#57025
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results6 tests failed, 93 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
dalexsoto
approved these changes
Nov 6, 2021
|
Test failures are unrelated:
Build is currently broken in main, waiting to merge until that's fixed (#13304). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #10470.