[Metal] Add support for xcode 13 beta5 . #12875

mandel-macaque · 2021-09-29T21:22:37Z

No description provided.

vs-mobiletools-engineering-service2 · 2021-09-30T01:02:56Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

15 tests failed, 87 tests passed.

Failed tests

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug: BuildFailure
introspection/tvOS - simulator/Debug: BuildFailure
introspection/watchOS 32-bits - simulator/Debug: BuildFailure
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): BuildFailure
introspection/tvOS - simulator/Debug (tvOS 11.4): BuildFailure
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): BuildFailure
monotouch-test/tvOS - simulator/Debug: BuildFailure
monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 7bce2b8 into af41600

vs-mobiletools-engineering-service2 · 2021-09-30T06:22:56Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

9 tests failed, 93 tests passed.

Failed tests

link sdk/Mac Catalyst [dotnet]/Release [dotnet]: Failed (Tests run: 129 Passed: 112 Inconclusive: 6 Failed: 1 Ignored: 16)
monotouch-test/tvOS - simulator/Debug: BuildFailure
monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure

Pipeline on Agent XAMBOT-1104.BigSur'
Merge f30fdb7 into af41600

src/Metal/MTLDevice.cs

tests/introspection/iOS/iOSApiSelectorTest.cs

src/metal.cs

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

vs-mobiletools-engineering-service2 · 2021-09-30T15:55:48Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge daa50ed into 3ffabb1

tj-devel709 · 2021-09-30T17:43:38Z

src/metal.cs

 		[Abstract, Export ("didModifyRange:")]
 		void DidModify (NSRange range);
-#endif
+	


nit: extra tab

tj-devel709 · 2021-09-30T17:48:42Z

src/metal.cs

 		[Export ("vertical")]
 		MTLRasterizationRateSampleArray Vertical { get; }
- */
+
+		[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst(15,0), NoWatch]


Suggested change

[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst(15,0), NoWatch]

[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst (15,0), NoWatch]

nit: spacing

tj-devel709 · 2021-09-30T17:49:00Z

src/metal.cs

+		[Export ("maxSampleCount")]
+		MTLSize MaxSampleCount { get; }
+
+		[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst(15,0), NoWatch]


Suggested change

[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst(15,0), NoWatch]

[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst (15,0), NoWatch]

nit: spacing

tj-devel709 · 2021-09-30T17:52:16Z

src/metal.cs

@@ -5243,4 +5563,152 @@ interface MTLFunctionLogDebugLocation {
 		nuint Column { get; }
 	}

+	[Mac (12,0), iOS (15,0), TV (15,0), MacCatalyst (15, 0), NoWatch]
+	[BaseType (typeof (NSObject))]
+	interface MTLStitchedLibraryDescriptor : NSCopying


Should all these "MTL..." classes be "Mtl..." ?

vs-mobiletools-engineering-service2 · 2021-09-30T22:19:44Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 97 tests passed.

Failed tests

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Debug: BuildFailure
monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure

Pipeline on Agent XAMBOT-1104.BigSur'
Merge ba86323 into 3ffabb1

vs-mobiletools-engineering-service2 · 2021-10-04T21:15:59Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 9ff5c7a into 05ad66d

mandel-macaque · 2021-10-05T18:01:08Z

/sudo backport xcode13-ios

vs-mobiletools-engineering-service2 · 2021-10-05T18:01:31Z

Backport Job to branch xcode13-ios Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-10-05T18:02:38Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5293493 for more details.

[Metal] Add support for xcode 13 beta5 .

7bce2b8

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Sep 29, 2021

chamons approved these changes Sep 29, 2021

View reviewed changes

Fix failing tests.

f30fdb7

rolfbjarne requested changes Sep 30, 2021

View reviewed changes

Apply suggestions from code review

daa50ed

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

tj-devel709 reviewed Sep 30, 2021

View reviewed changes

src/metal.cs

[Abstract, Export ("didModifyRange:")]

void DidModify (NSRange range);

#endif

Copy link

Contributor

tj-devel709 Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra tab

tj-devel709 reviewed Sep 30, 2021

View reviewed changes

Address reviews.

ba86323

rolfbjarne approved these changes Oct 1, 2021

View reviewed changes

Fix tests.

9ff5c7a

mandel-macaque merged commit 67e1ca5 into xamarin:main Oct 5, 2021

mandel-macaque deleted the metal-xcode13-beta5 branch October 5, 2021 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metal] Add support for xcode 13 beta5 . #12875

[Metal] Add support for xcode 13 beta5 . #12875

mandel-macaque commented Sep 29, 2021

vs-mobiletools-engineering-service2 commented Sep 30, 2021

Failed tests

vs-mobiletools-engineering-service2 commented Sep 30, 2021

Failed tests

vs-mobiletools-engineering-service2 commented Sep 30, 2021

tj-devel709 Sep 30, 2021

tj-devel709 Sep 30, 2021

tj-devel709 Sep 30, 2021

tj-devel709 Sep 30, 2021

vs-mobiletools-engineering-service2 commented Sep 30, 2021

Failed tests

vs-mobiletools-engineering-service2 commented Oct 4, 2021

Failed tests

mandel-macaque commented Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 5, 2021

	[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst(15,0), NoWatch]
	[Mac (12, 0), iOS (15, 0), TV (15,0), MacCatalyst (15,0), NoWatch]

[Metal] Add support for xcode 13 beta5 . #12875

[Metal] Add support for xcode 13 beta5 . #12875

Conversation

mandel-macaque commented Sep 29, 2021

vs-mobiletools-engineering-service2 commented Sep 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 30, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

tj-devel709 Sep 30, 2021

Choose a reason for hiding this comment

tj-devel709 Sep 30, 2021

Choose a reason for hiding this comment

tj-devel709 Sep 30, 2021

Choose a reason for hiding this comment

tj-devel709 Sep 30, 2021

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Oct 4, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mandel-macaque commented Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 5, 2021

vs-mobiletools-engineering-service2 commented Oct 5, 2021