Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Add a public target/property to make customers able to add to the PartialAppManifest item group in their own targets. Fixes #10646. #12645

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Sep 7, 2021

Also add a test.

Fixes #10646 (for the second time).

…to the PartialAppManifest item group in their own targets. Fixes xamarin#12336.

Also add a test.

Fixes xamarin#12336 (for the second time).
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Sep 7, 2021
@rolfbjarne rolfbjarne changed the title [msbuild] Add a public target/property to make customers able to add to the PartialAppManifest item group in their own targets. Fixes #12336. [msbuild] Add a public target/property to make customers able to add to the PartialAppManifest item group in their own targets. Fixes #10646. Sep 7, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 203 tests passed 🎉

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 4536a0a into 8bfa577

@rolfbjarne rolfbjarne merged commit a0fe8c0 into xamarin:main Sep 8, 2021
@rolfbjarne rolfbjarne deleted the dotnet-create-partial-app-manifests-target branch September 8, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
6 participants