Fixes Hot Restart build issues #12500
Conversation
This version contains fixes for building Maui projects with Hot Restart
The build was failing if `CodesignEntitlements` was not set, even though the CompileEntitlements task has a default value. That default value is not compatible with Hot Restart because it is a template file that exists on the Mac (and Hot Restart is an offline build from Windows). So if that property is not set we get the xcent file from the Hot Restart PreBuilt app bundle, which is essentially an empty plist.
On a Maui Single Project the app title can be set on the project file using the `ApplicationTitle` property. If that's set Hot Restart should include that value in the compiled app manifest, so the app name is shown on the device when the app is deployed.
|
Oh, and all these changes should be included in RC1 if possible 😬 |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
|
/sudo backport release/6.0.1xx-rc.1 |
|
Backport Job to branch release/6.0.1xx-rc.1 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5121723 for more details. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 142 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 142 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2479). |
The changes are explained on each commit :), two the problems fixed on this PR are related to Maui Single Projects.