-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIP] Add support for Xcode13 beta2. #12025
Merged
mandel-macaque
merged 19 commits into
xamarin:main
from
mandel-macaque:chip-xcode13-beta1
Jul 1, 2021
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0eea0e1
[CHIP] Add support for Xcode13 beta1.
mandel-macaque 1d6fac0
Merge branch 'main' into chip-xcode13-beta1
mandel-macaque 580d723
Remove framework from not supported os.
mandel-macaque 54bb4dd
Merge branch 'main' into chip-xcode13-beta1
mandel-macaque 805652d
Small style update.
mandel-macaque e1a541e
Merge branch 'chip-xcode13-beta1' of github.com:mandel-macaque/xamari…
mandel-macaque 815f5b2
Address reviews.
mandel-macaque 675a1c8
Merge branch 'main' into chip-xcode13-beta1
mandel-macaque d33146a
Readd framework for mac.
mandel-macaque 177d03a
Merge branch 'main' into chip-xcode13-beta1
mandel-macaque b02d9d0
Update src/chip.cs
mandel-macaque e416449
Update src/chip.cs
mandel-macaque f1bbc29
Re-add to other platforms for beta 2.
mandel-macaque 2820730
Merge branch 'chip-xcode13-beta1' of github.com:mandel-macaque/xamari…
mandel-macaque 401befe
[CHIP] Fix simulator tests on Release sim
dalexsoto c2c366c
Address reviews.
mandel-macaque 6740527
Merge branch 'main' into chip-xcode13-beta1
mandel-macaque 68837db
Update xtro after readding tvOS and watchOS.
mandel-macaque 8b53684
Merge branch 'main' into chip-xcode13-beta1
mandel-macaque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
tests/xtro-sharpie/MacCatalyst-CHIP.todo → tests/xtro-sharpie/MacCatalyst-CHIP.ignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
!missing-field! CHIPVersionNumber not bound | ||
!missing-field! CHIPVersionString not bound |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalexsoto out of curiosity, why doesn't the default case handle this?
xamarin-macios/tools/common/Target.cs
Lines 251 to 258 in 401befe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolfbjarne good question, I did not have a close look at it I wonder if there is a casing issue somewhere @mandel-macaque looks like we'll need to check deeper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking atm.