Try to prevent identical version numbers across branches by matching hardcoded prerelease identifiers with hardcoded branch name. #11893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hardcoded prerelease identifiers with hardcoded branch name. If we hardcode a prelease identifier for a .NET release, we can easily end up with multiple branches using the same version number, because the hardcoded prerelease identifier ends up being the same for any other branches that are created later from the release branch (one typical example would be backport branches). This is bad. So try to prevent this, by hardcoding two values instead! We'll hardcode the branch name where the hardcoded prerelease identifier should be applied, and this way any other branches will not use the hardcoded prerelease identifier. Ref: xamarin#11891.
rolfbjarne
added
not-notes-worthy
dalexsoto
approved these changes
Jun 10, 2021
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
spouliot
approved these changes
Jun 10, 2021
tj-devel709
approved these changes
Jun 10, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 113 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2454). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we hardcode a prelease identifier for a .NET release, we can easily end up
with multiple branches using the same version number, because the hardcoded
prerelease identifier ends up being the same for any other branches that are
created later from the release branch (one typical example would be backport
branches).
This is bad.
So try to prevent this, by hardcoding two values instead!
We'll hardcode the branch name where the hardcoded prerelease identifier
should be applied, and this way any other branches will not use the hardcoded
prerelease identifier.
Ref: #11891.