[CI] Detect if we are running a vm and set the vendor. #11471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
changed the title
rolfbjarne
approved these changes
May 6, 2021
spouliot
approved these changes
May 6, 2021
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 80 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur' |
|
/sudo backport d16-10 |
|
Backport Job to branch d16-10 Created! The magic is happening here |
|
/sudo backport release/6.0.1xx-preview4 |
|
Backport Job to branch release/6.0.1xx-preview4 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4732073 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4732109 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using vms for older machines, this results in certain tests that required hardware to fail, how can we skip those? If we find that there is a manufacturer that matches a known VM vendor, we set it in an env var.
Once this is landed, we can change tests to be skipped in vms. I just have 2 vendors I have tested this with, if anyone has another, we can add it.