-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Preserve a required method in System.Private.CoreLib to work around a bug in .NET 6. #10426
Merged
rolfbjarne
merged 1 commit into
xamarin:main
from
rolfbjarne:dotnet-tests-linker-bug-workaround
Jan 15, 2021
Merged
[tests] Preserve a required method in System.Private.CoreLib to work around a bug in .NET 6. #10426
rolfbjarne
merged 1 commit into
xamarin:main
from
rolfbjarne:dotnet-tests-linker-bug-workaround
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…around a bug in .NET 6. Ref: dotnet/runtime#46908.
spouliot
approved these changes
Jan 14, 2021
tj-devel709
approved these changes
Jan 14, 2021
mandel-macaque
approved these changes
Jan 14, 2021
dalexsoto
approved these changes
Jan 14, 2021
❌ Tests failed on Build ❌Tests failed on Build. Test results6 tests failed, 35 tests passed.Failed tests
Pipeline on Agent XAMBOT-1106 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
❌ Tests failed on Build ❌Tests failed on Build. Test results1 tests failed, 40 tests passed.Failed tests
Pipeline on Agent XAMBOT-1095' |
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2154) |
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Jun 17, 2021
…to work around a bug in .NET 6. (xamarin#10426)" This reverts commit 29727d6. dotnet/runtime#46908 was fixed and the other part of the workaround was removed in PR#11958
spouliot
added a commit
that referenced
this pull request
Jun 18, 2021
…to work around a bug in .NET 6. (#10426)" (#11974) This reverts commit 29727d6. dotnet/runtime#46908 was fixed and the other part of the workaround was removed in PR#11958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: dotnet/runtime#46908.