Inline UITraitChangeObservable in implementing classes #20265
Labels
Milestone
Comments
rolfbjarne
changed the title
rolfbjarne
changed the title
This was referenced Mar 6, 2024
|
@rolfbjarne As #13294 is closed, is this able to be implemented? |
I'll look into it and see what I can do. |
rolfbjarne
added a commit
that referenced
this issue
Nov 21, 2024
…that implement it. Fixes #20265. This also required fixing: * A bug in the static registrar where we'd ignore the generic parameters in a method when looking for methods implementing an interface. * A bug in the generator where we'd throw You_Should_Not_Call_base_In_This_Method() in some cases where we shouldn't. Also: * Enable nullability and fix any resulting issues. * Clean up some legacy code we don't need anymore. Ref: #19410 (comment) Fixes #20265.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up to #19410.
We need to inline the members of the
UITraitChangeObservableinterface into implementing types (UIView,UIViewController,UIPresentationController,UIWindowScene). This turned out a bit cumbersome to implement, because C# doesn't support calling the default interface member from an actual implementing member (#13294 (comment)).Here's the current WIP: rolfbjarne@5e09575 / https://github.com/rolfbjarne/xamarin-macios/commits/uitraitchangeobservable-inlined-edition
This is probably much easier to do once we've added support for default interface members (#13294), so postpone until then.
The text was updated successfully, but these errors were encountered: