Skip to content

Commit

Permalink
[tools] Enable the PushToTalk framework in the simulator. (#17274)
Browse files Browse the repository at this point in the history
Apple provides the headers to target PushToTalk (so using PushToTalk in code
builds just fine for the simulator in Xcode), but it doesn't work at runtime.

I believe it's better to allow the same thing in our bindings, for two reasons:

* Apple prints out a helpful error message at runtime, instead of our rather
  incomprehensible build error.
* Apple might implement simulator support in the future, in which case we
  won't need to do anything else.
  • Loading branch information
rolfbjarne authored Jan 18, 2023
1 parent b1957c9 commit ddda284
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/common/Frameworks.cs
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ public static Frameworks CreateiOSFrameworks (bool is_simulator_build)

{ "AVRouting", "AVRouting", 16,0},
{ "BackgroundAssets", "BackgroundAssets", 16,0},
{ "PushToTalk", "PushToTalk", new Version (16,0), NotAvailableInSimulator},
{ "PushToTalk", "PushToTalk", new Version (16,0), new Version (16, 2) /* available to build with, although it's unusable */},
{ "SharedWithYou", "SharedWithYou", 16, 0 },
{ "SharedWithYouCore", "SharedWithYouCore", 16, 0 },

Expand Down

4 comments on commit ddda284

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.