Skip to content

Commit

Permalink
[d17-2] Bump maccore to get fix for #14834. (#14958)
Browse files Browse the repository at this point in the history 
* [d17-2] Bump maccore to get fix for xamarin/maccorexamarin/maccore#14834.

New commits in xamarin/maccore:

* xamarin/maccore@29a1c1382e [mlaunch] Redirect stdout and stderr through a pty when launching in the simulator. Fixes #xamarin/xamarin-macios@14834.
* xamarin/maccore@749e84cb16 [mlaunch] Make minor improvements to Main.cs

Diff: https://github.com/xamarin/maccore/compare/cf9f7409e9a79d0d0835863cc9f5afe77ba5e74a..29a1c1382e005e568b57d1b45e3877c8081dfc8b

* [devops] Include d17-* as a trigger.

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
  • Loading branch information
@dalexsoto @rolfbjarne
dalexsoto and rolfbjarne authored May 11, 2022
1 parent 43e060a commit d24fab5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions mk/xamarin.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ MONO_BRANCH := $(shell cd $(MONO_PATH) 2> /dev/null && git symbolic-ref --sho
endif

ifdef ENABLE_XAMARIN
NEEDED_MACCORE_VERSION := cf9f7409e9a79d0d0835863cc9f5afe77ba5e74a
NEEDED_MACCORE_BRANCH := main
NEEDED_MACCORE_VERSION := 29a1c1382e005e568b57d1b45e3877c8081dfc8b
NEEDED_MACCORE_BRANCH := d17-2

MACCORE_DIRECTORY := maccore
MACCORE_MODULE := [email protected]:xamarin/maccore.git
Expand Down
1 change: 1 addition & 0 deletions tools/devops/automation/build-pipeline.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ pr:
include:
- main
- d16-*
- d17-*
- xcode*
- release/*
paths:
Expand Down

3 comments on commit d24fab5

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests on macOS Mac Catalina (10.15) passed ✅

Tests passed

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
[d17-2] Bump maccore to get fix for #14834. (#14958)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • linksdk
  • linkall
  • xammac_tests
  • monotouch-test

Pipeline on Agent
[d17-2] Bump maccore to get fix for #14834. (#14958)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found.

Pipeline on Agent XAMBOT-1030.Monterey'
[d17-2] Bump maccore to get fix for #14834. (#14958)

Please sign in to comment.