Address reviews.

xamarin · Jun 29, 2021 · c2c366c · c2c366c
1 parent 401befe
commit c2c366c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/frameworks.sources b/src/frameworks.sources
@@ -1893,7 +1893,6 @@ COMMON_FRAMEWORKS =         \
 	Accelerate              \
 	AuthenticationServices	\
 	AVFoundation            \
-	Chip                    \
 	CoreBluetooth           \
 	CoreData                \
 	CoreFoundation          \
@@ -1925,6 +1924,7 @@ MAC_FRAMEWORKS =            \
 	BusinessChat            \
 	CallKit \
 	CFNetwork               \
+	Chip                    \
 	ClassKit                \
 	CloudKit                \
 	Contacts                \
@@ -2025,6 +2025,7 @@ IOS_FRAMEWORKS =         \
 	CallKit \
 	CarPlay \
 	CFNetwork \
+	Chip \
 	ClassKit \
 	CloudKit \
 	Contacts \
@@ -2114,6 +2115,7 @@ IOS_FRAMEWORKS =         \
 
 WATCHOS_FRAMEWORKS =        \
 	$(COMMON_FRAMEWORKS)    \
+	Chip                    \
 	ClockKit                \
 	CloudKit                \
 	Contacts                \
@@ -2146,6 +2148,7 @@ TVOS_FRAMEWORKS =           \
 	AudioUnit               \
 	BackgroundTasks         \
 	CFNetwork               \
+	Chip                    \
 	CloudKit                \
 	CoreAnimation           \
 	CoreGraphics            \

diff --git a/tools/common/Frameworks.cs b/tools/common/Frameworks.cs
@@ -422,7 +422,7 @@ public static Frameworks CreateiOSFrameworks (bool is_simulator_build)
 
 				{ "CoreLocationUI", "CoreLocationUI", 15,0 },
 
-				{ "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator, true /* no headers in beta 2 */ }
+				{ "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator /* no headers in beta 2 */ }
 
 				// the above MUST be kept in sync with simlauncher
 				// see tools/mtouch/Makefile
@@ -491,7 +491,7 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build)
 				{ "Accessibility", "Accessibility", 7,0 },
 				{ "UniformTypeIdentifiers", "UniformTypeIdentifiers", 7,0 },
 
-				{ "Chip", "CHIP", new Version (8, 0), NotAvailableInSimulator, true /* no headers in beta 2 */ },
+				{ "Chip", "CHIP", new Version (8, 0), NotAvailableInSimulator /* no headers in beta 2 */ },
 
 			};
 		}
@@ -582,7 +582,7 @@ public static Frameworks TVOSFrameworks {
 					{ "UniformTypeIdentifiers", "UniformTypeIdentifiers", 14,0 },
 					{ "Intents", "Intents", 14,0 },
 
-					{ "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator, true /* no headers in beta 2 */ },
+					{ "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator /* no headers in beta 2 */ },
 				};
 			}
 			return tvos_frameworks;

diff --git a/tools/linker/ObjCExtensions.cs b/tools/linker/ObjCExtensions.cs
@@ -14,6 +14,7 @@ static class Namespaces {
 		public const string AppKit = nameof (AppKit);
 		public const string AVFoundation = nameof (AVFoundation);
 		public const string AVKit = nameof (AVKit);
+		public const string Chip = nameof (Chip);
 		public const string CloudKit = nameof (CloudKit);
 		public const string Contacts = nameof (Contacts);
 		public const string ContactsUI = nameof (ContactsUI);