Skip to content

Commit

Permalink
[dotnet] Add runtime packs to workload manifests (#12168)
Browse files Browse the repository at this point in the history 
Runtime pack entries should be included in all workload manifest files,
even though they will not yet be resolved from the packs folder due to
dotnet/sdk#14044.  These changes will also
allow us to start producing .msi files for the runtime packs for an
eventual inclusion in the Visual Studio installer.
  • Loading branch information
@pjcollins
pjcollins authored Jul 22, 2021
1 parent 76c8461 commit a150c1d
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 0 deletions.
10 changes: 10 additions & 0 deletions dotnet/targets/WorkloadManifest.MacCatalyst.template.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"packs": [
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]"
],
"extends": [
Expand All @@ -22,6 +24,14 @@
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "template",
"version": "@VERSION@"
Expand Down
20 changes: 20 additions & 0 deletions dotnet/targets/WorkloadManifest.iOS.template.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]"
],
"extends": [
Expand All @@ -27,6 +31,22 @@
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "template",
"version": "@VERSION@"
Expand Down
10 changes: 10 additions & 0 deletions dotnet/targets/WorkloadManifest.macOS.template.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"packs": [
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]"
],
"extends": [
Expand All @@ -22,6 +24,14 @@
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "template",
"version": "@VERSION@"
Expand Down
10 changes: 10 additions & 0 deletions dotnet/targets/WorkloadManifest.tvOS.template.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"packs": [
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]",
"Microsoft.@[email protected]"
],
"extends": [
Expand All @@ -22,6 +24,14 @@
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "framework",
"version": "@VERSION@"
},
"Microsoft.@[email protected]": {
"kind": "template",
"version": "@VERSION@"
Expand Down

7 comments on commit a150c1d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

Packages generated

View packages

Test results

21 tests failed, 203 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2491 Inconclusive: 35 Failed: 2 Ignored: 136)
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed (Not enough space on the root drive '/': 1009.79 MB left of 1024 MB required)
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed (Not enough space on the root drive '/': 1009.78 MB left of 1024 MB required)
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed (Not enough space on the root drive '/': 1009.78 MB left of 1024 MB required)
  • monotouch-test/watchOS 32-bits - simulator/Debug (all optimizations): Failed (Not enough space on the root drive '/': 1009.77 MB left of 1024 MB required)
  • link sdk/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 129 Passed: 105 Inconclusive: 6 Failed: 1 Ignored: 23)
  • [xUnit] Mono SystemXmlXunit/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.83 MB left of 1024 MB required)
  • [xUnit] Mono SystemRuntimeCompilerServicesUnsafeXunit/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.82 MB left of 1024 MB required)
  • [xUnit] Mono SystemNumericsXunit/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.82 MB left of 1024 MB required)
  • [xUnit] Mono MicrosoftCSharpXunit/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.82 MB left of 1024 MB required)
  • [xUnit] Mono SystemNetHttpUnitTestsXunit/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.81 MB left of 1024 MB required)
  • mscorlib Part 1/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.81 MB left of 1024 MB required)
  • mscorlib Part 2/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.8 MB left of 1024 MB required)
  • mscorlib Part 3/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.8 MB left of 1024 MB required)
  • [xUnit] Mono SystemCoreXunit Part 1/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.8 MB left of 1024 MB required)
  • [xUnit] Mono SystemCoreXunit Part 2/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.79 MB left of 1024 MB required)
  • [xUnit] Mono SystemXunit/watchOS 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 1009.79 MB left of 1024 MB required)
  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4) [dotnet]: Failed (Not enough space on the root drive '/': 958.96 MB left of 1024 MB required)
  • introspection/tvOS - simulator/Debug (tvOS 11.4): Failed (Not enough space on the root drive '/': 960.02 MB left of 1024 MB required)
  • introspection/tvOS - simulator/Debug (tvOS 11.4) [dotnet]: Failed (Not enough space on the root drive '/': 960.02 MB left of 1024 MB required)
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Failed (Not enough space on the root drive '/': 960.02 MB left of 1024 MB required)

Pipeline on Agent XAMBOT-1038.BigSur'
[dotnet] Add runtime packs to workload manifests (#12168)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS 🔥

Not enough free space in the host.

Pipeline on Agent
[dotnet] Add runtime packs to workload manifests (#12168)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[dotnet] Add runtime packs to workload manifests (#12168)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[dotnet] Add runtime packs to workload manifests (#12168)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Catalina (10.15) ✅

Tests passed

All tests on macOS X Mac Catalina (10.15) passed.

Pipeline on Agent
[dotnet] Add runtime packs to workload manifests (#12168)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[dotnet] Add runtime packs to workload manifests (#12168)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac High Sierra (10.13) ✅

Tests passed

All tests on macOS X Mac High Sierra (10.13) passed.

Pipeline on Agent
[dotnet] Add runtime packs to workload manifests (#12168)

Please sign in to comment.