Skip to content

Commit

Permalink
Revert "[dotnet] add redirect-class-handles to optimizations. (#18354)"
Browse files Browse the repository at this point in the history
This reverts commit 62634bd.
  • Loading branch information
dalexsoto authored May 31, 2023
1 parent 2606b23 commit 82fc879
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions tools/common/Optimizations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public class Optimizations {
"custom-attributes-removal",
"experimental-xforms-product-type",
"force-rejected-types-removal",
"redirect-class-handles",
};

static ApplePlatform [] [] valid_platforms = new ApplePlatform [] [] {
Expand All @@ -49,7 +48,6 @@ public class Optimizations {
/* Opt.CustomAttributesRemoval */ new ApplePlatform [] { ApplePlatform.iOS, ApplePlatform.MacOSX, ApplePlatform.WatchOS, ApplePlatform.TVOS, ApplePlatform.MacCatalyst },
/* Opt.ExperimentalFormsProductType */ new ApplePlatform [] { ApplePlatform.iOS, ApplePlatform.MacOSX, ApplePlatform.WatchOS, ApplePlatform.TVOS, ApplePlatform.MacCatalyst },
/* Opt.ForceRejectedTypesRemoval */ new ApplePlatform [] { ApplePlatform.iOS, ApplePlatform.WatchOS, ApplePlatform.TVOS, ApplePlatform.MacCatalyst },
/* Opt.RedirectClassHandles */ new ApplePlatform [] { ApplePlatform.iOS, ApplePlatform.MacOSX, ApplePlatform.WatchOS, ApplePlatform.TVOS, ApplePlatform.MacCatalyst },
};

enum Opt {
Expand All @@ -71,7 +69,6 @@ enum Opt {
CustomAttributesRemoval,
ExperimentalFormsProductType,
ForceRejectedTypesRemoval,
RedirectClassHandles,
}

bool? [] values;
Expand Down Expand Up @@ -158,11 +155,6 @@ public bool? ForceRejectedTypesRemoval {
set { values [(int) Opt.ForceRejectedTypesRemoval] = value; }
}

public bool? RedirectClassHandles {
get { return values [(int) Opt.RedirectClassHandles]; }
set { values [(int) Opt.RedirectClassHandles] = value; }
}

public Optimizations ()
{
values = new bool? [opt_names.Length];
Expand Down Expand Up @@ -204,7 +196,6 @@ public void Initialize (Application app, out List<ProductException> messages)
break; // Does not require linker
case Opt.RegisterProtocols:
case Opt.RemoveDynamicRegistrar:
case Opt.RedirectClassHandles:
if (app.Registrar != RegistrarMode.Static && app.Registrar != RegistrarMode.ManagedStatic) {
messages.Add (ErrorHelper.CreateWarning (2003, Errors.MT2003, (values [i].Value ? "" : "-"), opt_names [i]));
values [i] = false;
Expand Down

6 comments on commit 82fc879

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 82fc8790fbec26709c9ef0359a892199ac8dc506 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 82fc8790fbec26709c9ef0359a892199ac8dc506 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [CI build]

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.