-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[monotouch-test] Fix the BaseEffectTest and EffectPropertyMaterialTes…
…t tests. (#14243) The [Culture ("en")] attribute means: only run this test if the culture is "en". This usually meant not running this test (apparently we don't run often with culture = "en"), leading to outdated tests that happened to fail when actually run under culture = "en" (such as on older macOS bots). So change these tests to actually change the culture to "en" (by using the SetCulture attribute), and also fix them.
- Loading branch information
1 parent
2a1f24f
commit 681b45b
Showing
2 changed files
with
25 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
681b45b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Tests failed on Build ❌
Tests failed on Build.
API diff
✅ API Diff from stable
View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff
API Current PR diff
ℹ️ API Diff (from PR only) (please review changes)
View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff
Generator diff
✅ Generator Diff (no change)
Packages generated
View packages
Test results
1 tests failed, 234 tests passed.
Failed tests
Tests run: 11943 Passed: 10499 Inconclusive: 0 Failed: 3 Ignored: 354)
Pipeline on Agent XAMBOT-1036.BigSur'
[monotouch-test] Fix the BaseEffectTest and EffectPropertyMaterialTest tests. (#14243)
681b45b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tests passed on macOS Mac Catalina (10.15) ✅
Tests passed
All tests on macOS X Mac Catalina (10.15) passed.
Pipeline on Agent
[monotouch-test] Fix the BaseEffectTest and EffectPropertyMaterialTest tests. (#14243)
681b45b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥
Result file D:\a\1\s\Reports\TestSummary-iOS64\TestSummary.md not found.
Pipeline on Agent
[monotouch-test] Fix the BaseEffectTest and EffectPropertyMaterialTest tests. (#14243)