Skip to content

Commit

Permalink
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)
Browse files Browse the repository at this point in the history
  • Loading branch information
mandel-macaque authored Jun 23, 2021
1 parent 7b934c8 commit 1f84aaa
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 22 deletions.
27 changes: 27 additions & 0 deletions src/corespotlight.cs
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,19 @@ interface CSSearchableItemAttributeSet : NSCopying, NSSecureCoding {
[NullAllowed, Export ("supportsNavigation", ArgumentSemantic.Strong)]
NSNumber SupportsNavigation { get; set; }

[NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[Field ("CSActionIdentifier")]
NSString ActionIdentifier { get; }

[NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[Export ("actionIdentifiers", ArgumentSemantic.Copy)]
string[] ActionIdentifiers { get; set; }

[NullAllowed]
[NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[Export ("sharedItemContentType", ArgumentSemantic.Copy)]
UTType SharedItemContentType { get; set; }

// CSContainment

[NullAllowed, Export ("containerTitle")]
Expand Down Expand Up @@ -1030,6 +1043,10 @@ interface CSSearchableItemAttributeSet : NSCopying, NSSecureCoding {
[iOS (11, 0), NoTV]
[NullAllowed, Export ("rankingHint", ArgumentSemantic.Strong)]
NSNumber RankingHint { get; set; }

[NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
[NullAllowed, Export ("darkThumbnailURL", ArgumentSemantic.Strong)]
NSUrl DarkThumbnailUrl { get; set; }

// CSSearchableItemAttributeSet_CSItemProvider

Expand Down Expand Up @@ -1075,5 +1092,15 @@ interface CSSearchQuery {
[Export ("cancel")]
void Cancel ();
}

[Abstract]
[NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
[BaseType (typeof (NSObject))]
interface CSImportExtension : NSExtensionRequestHandling
{
[Export ("updateAttributes:forFileAtURL:error:")]
bool Update (CSSearchableItemAttributeSet attributes, NSUrl contentUrl, [NullAllowed] out NSError error);
}

}

9 changes: 9 additions & 0 deletions tests/introspection/ApiSelectorTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,15 @@ protected virtual bool Skip (Type type, string selectorName)
return Runtime.Arch == Arch.SIMULATOR;
}
break;
case "CSImportExtension":
switch (selectorName) {
case "beginRequestWithExtensionContext:":
case "updateAttributes:forFileAtURL:error:":
if (Runtime.Arch == Arch.SIMULATOR) // not available in the sim
return true;
break;
}
break;
#endif
case "WKPreferences":
switch (selectorName) {
Expand Down
9 changes: 0 additions & 9 deletions tests/xtro-sharpie/MacCatalyst-CoreSpotlight.todo

This file was deleted.

9 changes: 0 additions & 9 deletions tests/xtro-sharpie/iOS-CoreSpotlight.todo

This file was deleted.

4 changes: 0 additions & 4 deletions tests/xtro-sharpie/macOS-CoreSpotlight.todo

This file was deleted.

8 comments on commit 1f84aaa

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

Packages generated

View packages

Test results

33 tests failed, 188 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2451 Passed: 2393 Inconclusive: 13 Failed: 1 Ignored: 57)
  • monotouch-test/Mac [dotnet]/Debug (CoreCLR) [dotnet]: Failed (Test run failed.
    Tests run: 2451 Passed: 2393 Inconclusive: 13 Failed: 1 Ignored: 57)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: TimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
  • fsharp/iOS Unified 64-bits - simulator/Debug: TimedOut
  • framework-test/iOS Unified 64-bits - simulator/Debug: TimedOut
  • xcframework-test/iOS Unified 64-bits - simulator/Debug: TimedOut
  • interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug: TimedOut
  • interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
  • introspection/iOS Unified 64-bits - simulator/Debug: TimedOut
  • introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
  • dont link/iOS Unified 64-bits - simulator/Debug: TimedOut
  • dont link/iOS Unified 64-bits - simulator/Release: TimedOut
  • dont link/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
  • dont link/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
  • link all/iOS Unified 64-bits - simulator/Debug: TimedOut
  • link all/iOS Unified 64-bits - simulator/Release: TimedOut
  • link all/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
  • link all/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
  • link sdk/iOS Unified 64-bits - simulator/Debug: TimedOut
  • link sdk/iOS Unified 64-bits - simulator/Release: TimedOut
  • link sdk/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
  • link sdk/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
  • mono-native-compat/iOS Unified 64-bits - simulator/Debug: TimedOut
  • mono-native-compat/iOS Unified Today Extension 64-bits - simulator/Debug: TimedOut
  • mono-native-unified/iOS Unified 64-bits - simulator/Debug: TimedOut
  • mono-native-unified/iOS Unified Today Extension 64-bits - simulator/Debug: TimedOut
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - simulator/Debug: TimedOut
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - simulator/Debug: TimedOut
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - simulator/Debug: TimedOut
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - simulator/Debug: TimedOut
  • [xUnit] Mono BCL tests group 5/iOS Unified 64-bits - simulator/Debug: TimedOut
  • mscorlib Part 1/iOS Unified 64-bits - simulator/Debug: TimedOut

Pipeline on Agent XAMBOT-1025.BigSur'
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS 🔥

Not enough free space in the host.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Catalina (10.15) ✅

Tests passed

All tests on macOS X Mac Catalina (10.15) passed.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac High Sierra (10.13) ✅

Tests passed

All tests on macOS X Mac High Sierra (10.13) passed.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS32b). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[CoreSpotlight] Add Xcode13 beta1 support. (#11986)

Please sign in to comment.