Skip to content

Commit

Permalink
[tests][monotouch-test] Re-enable registrar test for conformsToProtoc…
Browse files Browse the repository at this point in the history 
…ol for dotnet (#12411)

This works fine now. I'm fairly sure this was fixed when the the last
custom steps of the linker were ported for dotnet illink

Fix #11540
  • Loading branch information
@spouliot
spouliot authored Aug 12, 2021
1 parent 0a88e59 commit 1c937ac
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions tests/monotouch-test/ObjCRuntime/RegistrarTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1374,9 +1374,7 @@ public void TestProtocolRegistration ()
Assert.AreNotEqual (IntPtr.Zero, Runtime.GetProtocol (iProtocol), "IProtocol");
Assert.IsTrue (Messaging.bool_objc_msgSend_IntPtr (Class.GetHandle (typeof (MyProtocolImplementation)), Selector.GetHandle ("conformsToProtocol:"), Runtime.GetProtocol (iProtocol)), "Interface/IProtocol");
#if !__TVOS__ && !__WATCHOS__ && !MONOMAC
#if !NET // https://github.com/xamarin/xamarin-macios/issues/11540
Assert.IsTrue (Messaging.bool_objc_msgSend_IntPtr (Class.GetHandle (typeof (Test24970)), Selector.GetHandle ("conformsToProtocol:"), Protocol.GetHandle ("UIApplicationDelegate")), "UIApplicationDelegate/17669");
#endif
#endif
// We don't support [Adopts] (yet at least).
// Assert.IsTrue (Messaging.bool_objc_msgSend_IntPtr (Class.GetHandle (typeof (ConformsToProtocolTestClass)), Selector.GetHandle ("conformsToProtocol:"), Runtime.GetProtocol ("NSCoding")), "Adopts/ConformsToProtocolTestClass");
Expand Down

4 comments on commit 1c937ac

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

Packages generated

View packages

Test results

2 tests failed, 231 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2488 Inconclusive: 36 Failed: 1 Ignored: 149)
  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1036.BigSur'
[tests][monotouch-test] Re-enable registrar test for conformsToProtocol for dotnet (#12411)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[tests][monotouch-test] Re-enable registrar test for conformsToProtocol for dotnet (#12411)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[tests][monotouch-test] Re-enable registrar test for conformsToProtocol for dotnet (#12411)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[tests][monotouch-test] Re-enable registrar test for conformsToProtocol for dotnet (#12411)

Please sign in to comment.