Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Abstractify old webkit api #14

Closed

Conversation

atsushieno
Copy link
Contributor

As part of discussion at dotnet/android#1078 (comment) ,
we decided to make changes to those inconsistent methods that used to be
virtual and then became abstract, to become abstract even in old API level.

It is done at metadata fixup level.

(copying the commitmsg from dotnet/android#1304)

As part of discussion at dotnet/android#1078 (comment) ,
we decided to make changes to those inconsistent methods that used to be
virtual and then became abstract, to become abstract even in old API level.

It is done at metadata fixup level.

(copying the commitmsg from dotnet/android#1304)
@atsushieno atsushieno force-pushed the abstractify-old-webkit-api branch from 8ed464b to 4ed7d09 Compare February 22, 2018 16:49
@atsushieno
Copy link
Contributor Author

rebased onto the latest master.

@jonpryor
Copy link
Member

@atsushieno: Do you have the HTML-based API diff handy?

@atsushieno
Copy link
Contributor Author

Not an exact output, but it is on what my changes are based (reported as inter-api diff between 8.0 and 8.1 as I didn't waste time on building everything on master):

<h1>### API BREAK BETWEEN v8.0 and v8.1</h1>
<!-- start namespace Android.Webkit --> <div> 
<h2>Namespace Android.Webkit</h2>
<!-- start type WebHistoryItem --> <div>
<h3>Type Changed: Android.Webkit.WebHistoryItem</h3>
<p>Modified properties:</p>
<pre>
<div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> int Id { get; }
</div></pre>

</div> <!-- end type WebHistoryItem -->
<!-- start type WebSettings --> <div>
<h3>Type Changed: Android.Webkit.WebSettings</h3>
<p>Modified properties:</p>
<pre>
<div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> bool NavDump { get; set; }
</div><div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> bool PluginsEnabled { get; set; }
</div><div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> string PluginsPath { get; set; }
</div><div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> bool UseDoubleTree { get; set; }
</div><div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> bool UseWebViewBackgroundForOverscrollBackground { get; set; }
</div><div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> int UserAgent { get; set; }
</div></pre>
<p>Modified methods:</p>
<pre>
<div data-is-breaking>	public <span class='added added-breaking-inline'>abstract</span> WebSettings.TextSize GetTextSize ()
</div></pre>

</div> <!-- end type WebSettings -->

</div> <!-- end namespace Android.Webkit -->
Makefile:122: recipe for target 'check-inter-api-level' failed

@jonpryor
Copy link
Member

Context: dotnet/android#1304

@atsushieno
Copy link
Contributor Author

Closing as per dotnet/android#1304 (comment)

@atsushieno atsushieno closed this Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants