Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Remove experimental flag for shell and change a few apis #6086

Merged
merged 10 commits into from
May 9, 2019

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented May 4, 2019

Description of Change

Remove the experimental flag, rename all the apis that are Shell.GetShell, and internalize some types

Issues Resolved

API Changes

Changed:

  • Shell.ShellBackgroundColor => Shell.BackgroundColor
  • Shell.ShellTitleColor=> Shell.TitleColor
  • Shell.ShellDisabledColor => Shell.DisabledColor
  • Shell.ShellUnselectedColor => Shell.UnselectedColor
  • Shell.ShellForegroundColor => Shell.ForegroundColor

Removed:

  • ShellItemCollection (made internal)
  • ShellSectionCollection (made internal)
  • ShellContentCollection (made internal)
  • ShellSection.NavigationImpl (made internal)
  • Shell.NavigationImpl (made internal)

Platforms Affected

  • Core/XAML (all platforms)

Testing Procedure

  • make sure shell works
  • look through shell, shell section, shell item, shell content and see if there's anything else we should hide/expose

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@PureWeen PureWeen added this to the 4.0.0 milestone May 4, 2019
@PureWeen PureWeen requested a review from davidortinau May 4, 2019 01:14
@PureWeen PureWeen requested a review from StephaneDelcroix as a code owner May 4, 2019 01:14
@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label May 4, 2019
Xamarin.Forms.Core/Shell/Shell.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Core/Shell/ShellItem.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Core/Shell/ShellItemCollection.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Core/Shell/ShellSection.cs Outdated Show resolved Hide resolved
@samhouts samhouts removed the request for review from davidortinau May 6, 2019 22:32
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 Issues/Gh5705.xaml.cs(26,60): error CS0117: 'ExperimentalFlags' does not contain a definition for 'ShellExperimental' [/Users/vsts/agent/2.150.3/work/1/s/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj]
  Issues/Gh5706.xaml.cs(38,60): error CS0117: 'ExperimentalFlags' does not contain a definition for 'ShellExperimental' [/Users/vsts/agent/2.150.3/work/1/s/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj

@PureWeen PureWeen requested a review from samhouts May 7, 2019 16:57
@rmarinho rmarinho merged commit 03e9a9f into 4.0.0 May 9, 2019
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 2, 2019
@PureWeen PureWeen deleted the shell_official branch September 2, 2019 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 a/Xaml </> approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. t/enhancement ➕
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants