This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Remove experimental flag for shell and change a few apis #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
blocker
Issue blocks next stable release. Prioritize fixing and reviewing this issue.
label
May 4, 2019
paymicro
reviewed
May 6, 2019
samhouts
suggested changes
May 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues/Gh5705.xaml.cs(26,60): error CS0117: 'ExperimentalFlags' does not contain a definition for 'ShellExperimental' [/Users/vsts/agent/2.150.3/work/1/s/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj]
Issues/Gh5706.xaml.cs(38,60): error CS0117: 'ExperimentalFlags' does not contain a definition for 'ShellExperimental' [/Users/vsts/agent/2.150.3/work/1/s/Xamarin.Forms.Xaml.UnitTests/Xamarin.Forms.Xaml.UnitTests.csproj
StephaneDelcroix
approved these changes
May 7, 2019
samhouts
approved these changes
May 7, 2019
paymicro
approved these changes
May 8, 2019
Co-Authored-By: PureWeen <[email protected]>
Co-Authored-By: PureWeen <[email protected]>
Co-Authored-By: PureWeen <[email protected]>
Co-Authored-By: PureWeen <[email protected]>
samhouts
added
the
approved
Has two approvals, no pending reviews, and no changes requested
label
Jul 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/shell 🐚
a/Xaml </>
approved
Has two approvals, no pending reviews, and no changes requested
blocker
Issue blocks next stable release. Prioritize fixing and reviewing this issue.
t/enhancement ➕
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove the experimental flag, rename all the apis that are Shell.GetShell, and internalize some types
Issues Resolved
API Changes
Changed:
Removed:
Platforms Affected
Testing Procedure
PR Checklist