Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Shell] The glorious Shell #4522

Merged
merged 15 commits into from
Nov 30, 2018
Merged

[Shell] The glorious Shell #4522

merged 15 commits into from
Nov 30, 2018

Conversation

StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Nov 23, 2018 •
edited by samhouts
Loading

the glorious shell, as-is, behind a feature flag. some parts still need love/fixes

fixes #2415

Breaking Changes

  • [Android] ScrollViewRenderer now inherits from NestedScrollView

@StephaneDelcroix StephaneDelcroix force-pushed the shell-master branch 4 times, most recently from 0940b85 to f32263b Compare November 26, 2018 19:17
@rmarinho
Copy link
Member

We need to try to figure why so many UITests are failing

rmarinho
rmarinho suggested changes Nov 28, 2018
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing uitests and I can replicate locally, looking at the Android ones first.

PureWeen
PureWeen previously requested changes Nov 28, 2018
View reviewed changes
Xamarin.Forms.Core/DataTemplate.cs Show resolved Hide resolved
Xamarin.Forms.Core/DependencyService.cs Show resolved Hide resolved
@StephaneDelcroix StephaneDelcroix force-pushed the shell-master branch 2 times, most recently from e3333bd to 6bb935e Compare November 29, 2018 12:23
@samhouts samhouts merged commit 78385f9 into master Nov 30, 2018
@samhouts samhouts deleted the shell-master branch November 30, 2018 04:23
@weitzhandler
Copy link

Thanks for the great work.
Now the only thing Xamarin.Forms lacks is be compliant to UWP or WPF syntax.

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018
@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019
@samhouts samhouts added the breaking Changes behavior or appearance label Feb 26, 2019
samhouts added a commit that referenced this pull request Feb 26, 2019
@samhouts
Add null checks on new code paths added in #4522
32bad6e 
fixes #5161
This was referenced Feb 26, 2019
Closed
Merged
@samhouts samhouts added the API-change Heads-up to reviewers that this PR may contain an API change label Feb 26, 2019
samhouts added a commit that referenced this pull request Feb 28, 2019
@samhouts
[iOS, Android] Prevent NREs in ScrollViews (#5383)
0b7965f 
* Add null checks on new code paths added in #4522

fixes #5161

* Fix cast...

Fixes #5247
@paymicro paymicro mentioned this pull request Mar 1, 2019
Merged
3 tasks
@King-Xero King-Xero mentioned this pull request Jul 12, 2019
Closed
@DineshBabuYadav DineshBabuYadav mentioned this pull request Sep 18, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sergiojoel9877 Sergiojoel9877 Sergiojoel9877 left review comments

@samhouts samhouts samhouts approved these changes

@davidortinau davidortinau davidortinau left review comments

@jassmith jassmith jassmith left review comments

@PureWeen PureWeen PureWeen approved these changes

@hartez hartez Awaiting requested review from hartez

@rmarinho rmarinho Awaiting requested review from rmarinho

@kingces95 kingces95 Awaiting requested review from kingces95

Assignees
No one assigned
Labels
a/shell 🐚 API-change Heads-up to reviewers that this PR may contain an API change breaking Changes behavior or appearance e/10:clock10: 10 t/enhancement ➕
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Xamarin.Forms.Shell Spec
8 participants
@StephaneDelcroix @rmarinho @weitzhandler @jassmith @davidortinau @PureWeen @samhouts @Sergiojoel9877