This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Add net6.0 target framework, bump editor #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference MS.VS.Language explicitly to work around restore bug.
mrward
approved these changes
Mar 4, 2022
sandyarmstrong
commented
Mar 4, 2022
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Reference Include="System.ComponentModel.Composition" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Turn off windows dependency check. Some packages still have windows-specific dependencies, even though in the cases that matter they are not used at run-time --> | ||
| <Target Name="IgnoreWindowsReferenceError" BeforeTargets="_CheckForTransitiveWindowsDesktopDependencies"> |
There was a problem hiding this comment.
This target should only be necessary when a net6.0* project references net472 nupkgs. In this project, every package should resolve as netstandard2.0 for the net6.0 target framework, but for some reason NuGet is resolving them as net472, triggering this error and also NuGet/Home#5957.
There was a problem hiding this comment.
I should note that this happens even if I remove the net472 from TargetFrameworks completely.
KirillOsenkov
approved these changes
Mar 4, 2022
sandyarmstrong
commented
Mar 4, 2022
| - name: Test (Windows) | ||
| if: startsWith (matrix.os, 'windows') | ||
| run: dotnet test -c ${{ matrix.config }} --no-build | ||
| # - name: Test (Windows) |
There was a problem hiding this comment.
Tests won't work unless minieditor gets updated.
There was a problem hiding this comment.
we don’t care at this point
|
Can you do me a favor and merge/bump? thanks. Let me know if I can help with any tasks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference MS.VS.Language explicitly to work around restore bug.