Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #62 #63

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Fix issue #62 #63

merged 2 commits into from
Feb 1, 2019

Conversation

foxanna
Copy link
Contributor

@foxanna foxanna commented Feb 1, 2019

This PR contains fix of issue #62 suggested by @Phenek.
It allows avoiding IndexOutOfRange exception. Besides, it solves cases when a page with attached TabBadge.Badge*Property lies within a parent, while it should not affect exising use cases.

@foxanna foxanna changed the title Fix issue https://github.com/xabre/xamarin-forms-tab-badge/issues/62 Fix issue #62 Feb 1, 2019
@Phenek
Copy link

Phenek commented Feb 1, 2019

Thanks Foxanna to make this PR.
Regards 👍

@xabre
Copy link
Owner

xabre commented Feb 1, 2019

Thanks for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants