-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XF 3.1] Android bottom tab bar position #48
Comments
I think the best way is to build a new custom renderer to integrate with
the plugin you specified
…On Fri, Jun 8, 2018, 7:51 AM Vivek Shah ***@***.***> wrote:
I have integrated this plugin in my app and works as expected, but now I
want to show this tab bar at the bottom position in android, can anyone
have some idea for that? I have tried this
<https://github.com/NAXAM/bottomtabbedpage-xamarin-forms> plugin, but a
combination of this both plugin doesn't work. Please help me to get out of
this task.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#48>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AF6sHnqjTRi7wfjVx-066drPuSaDEaVQks5t6hDYgaJpZM4UfiAk>
.
|
This is now supported by the built in Xamarin.Forms TabbedPageRenderer as of 3.1.0.550168-pre3. It's based on the native The placement is controlled with a platform specific |
@GalaxiaGuy I think this is the best way to go now :) An adapted renderer for XF 3.1 |
@xabre Are you working for the new XF 3.1 version ? |
I did this as a spike: It's far from ready for release though:
This version involved changing the original renderer as little as possible - it grabs the correct view from the I think to do it properly a separate BadgeView would be needed, but I doubt will have time in the immediate future. |
Hi guys ! Is there any work around to implement badge on Bottom Tabbed Page by Xamain.Forms 3.1 ? thanks ! |
Pull requests are welcome :) |
Pre-release with XF 3.1 android bottom tab placement suport is out: https://www.nuget.org/packages/Plugin.Badge/2.1.0-pre.2 Please give it a try and let me know if you spot some problems. PS: you can use the BadgeMargin property to fine tune the position. |
Hi @xabre ,
Thanks |
Hi @xabre I think the animation where the icon is made a bit larger, moves up a bit and is changes the color is no longer present. |
@NPadrutt thanks for the feedback, I think I know what is causing this, when the badge is attached to the icon a new parent container layout is added which might affect this behaviour. Will have to find an alternative way to add the badge view without affecting the existing layout structure....
|
@IoTFier yes some additional logs would be helpful, like a full stack trace. Alos does it work without your custom renderer (directly with the badgedrenderer)? |
@reense Yes, I know what the issue is, will try to find a proper fix :) |
@xabre Great to hear! Looking forward to it :) |
Hi @xabre, good news is that the badge is working without the custom renderer. Apparently, I am looking for opensource nuget package / plugin that will allow me to host tabbed bar on top in Andriod and in iOS; offers bindable properties to change tab bar height, apply font icons in conjunction with your badge and allow to change text case in Android (which is capital always). Any recommendations on that ? Thanks |
@IoTFier what do you mean with "working without a custom renderer"? |
@reense, I tried to use a NuGet package BadgedPlatformTabbedPage which has custom renderer for TabbedPage. |
For me, either. |
@xabre, how are you? Just wanted to know when is the next update coming for 2.1.0? |
@IoTFier @chien1219 I would need some sample custom renderer which is not working to debug this. Most probably your custom renderer changed something in the standard view hierarchy and the badge renderer can't find the proper view.layout to attach to. |
@xabre I upgrade on my project and it looks very nice now. Thanks for your effort! |
@xabre thank you for your work! works like a charm now. The users of my app are thankfull ;) |
I have integrated this plugin in my app and works as expected, but now I want to show this tab bar at the bottom position in android, can anyone have some idea for that? I have tried this plugin, but a combination of this both plugin doesn't work. Please help me to get out of this task.
The text was updated successfully, but these errors were encountered: