Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: unsupported operand type(s) for /: 'NoneType' and 'int' #345

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ilankas
Copy link

@ilankas ilankas commented Sep 6, 2024

This is to fix "TypeError" durin HA startup.

  File "/config/custom_components/localtuya/switch.py", line 82, in extra_state_attributes
    attrs[ATTR_VOLTAGE] = self.dp_value(self._config[CONF_VOLTAGE]) / 10
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
TypeError: unsupported operand type(s) for /: 'NoneType' and 'int'

Comment on lines 75 to 87
if self.has_config(CONF_CURRENT_CONSUMPTION):
attrs[ATTR_CURRENT_CONSUMPTION] = (
self.dp_value(self._config[CONF_CURRENT_CONSUMPTION]) / 10
)
value_cc = self.dp_value(self._config[CONF_CURRENT_CONSUMPTION])
if value_cc is not None:
attrs[ATTR_CURRENT_CONSUMPTION] = value_cc / 10
else:
attrs[ATTR_CURRENT_CONSUMPTION] = None

if self.has_config(CONF_VOLTAGE):
attrs[ATTR_VOLTAGE] = self.dp_value(self._config[CONF_VOLTAGE]) / 10
value_v = attrs[ATTR_VOLTAGE] = self.dp_value(self._config[CONF_VOLTAGE])
if value_v is not None:
attrs[ATTR_VOLTAGE] = value_v / 10
else:
attrs[ATTR_VOLTAGE] = None
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.has_config(CONF_CURRENT_CONSUMPTION):
attrs[ATTR_CURRENT_CONSUMPTION] = (
self.dp_value(self._config[CONF_CURRENT_CONSUMPTION]) / 10
)
value_cc = self.dp_value(self._config[CONF_CURRENT_CONSUMPTION])
if value_cc is not None:
attrs[ATTR_CURRENT_CONSUMPTION] = value_cc / 10
else:
attrs[ATTR_CURRENT_CONSUMPTION] = None
if self.has_config(CONF_VOLTAGE):
attrs[ATTR_VOLTAGE] = self.dp_value(self._config[CONF_VOLTAGE]) / 10
value_v = attrs[ATTR_VOLTAGE] = self.dp_value(self._config[CONF_VOLTAGE])
if value_v is not None:
attrs[ATTR_VOLTAGE] = value_v / 10
else:
attrs[ATTR_VOLTAGE] = None
if self.has_config(CONF_CURRENT_CONSUMPTION):
val_cc = self.dp_value(self._config[CONF_CURRENT_CONSUMPTION])
attrs[ATTR_CURRENT_CONSUMPTION] = None if val_cc is None else val_cc / 10
if self.has_config(CONF_VOLTAGE):
val_vol = self.dp_value(self._config[CONF_VOLTAGE])
attrs[ATTR_VOLTAGE] = None if val_vol is None else val_vol / 10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code amended based on review.

@xZetsubou
Copy link
Owner

Thanks

@xZetsubou xZetsubou merged commit e23d2c4 into xZetsubou:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants