Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option for variable pin length #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

digitalhoax
Copy link

This PR adds the option to have a variable pin length. it adjusts the displayed dots accordingly and has a confirm button so you can confirm the pin.

@xPutnikx
Copy link
Owner

hi @digitalhoax ,
Thanks for contribution.

I see the point of having a flexible length, it makes sense, I will test your solution first to make sure it doesn't add unnecessary complexity to the package.

@xPutnikx
Copy link
Owner

Screenshot 2022-06-13 at 22 09 56

Screenshot 2022-06-13 at 22 11 11

I guess some limitation should be added to prevent user from entering way too many symbols.

For example Samsung limits up to 16 digits, with the current default dot size seems like 12 items fit the best.
@digitalhoax what do you think?

@digitalhoax
Copy link
Author

Yes, this seems an obvious improvement that needs to be made. Will get to it shortly and update the PR accordingly.

@digitalhoax
Copy link
Author

I have limited the maximum number of chars to ten as that is what fits on some of my test devices' screen. Might be an option to decrease the font size on longer pins if the need for it arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants