Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda env yml files and add missing dependencies #307

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Aug 10, 2022

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Aug 10, 2022
@tomvothecoder tomvothecoder changed the title Add xesmf back to the dev env Update conda env yml files and add missing dependencies Aug 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #307 (3518c21) into main (050d57e) will not change coverage.
The diff coverage is n/a.

❗ Current head 3518c21 differs from pull request most recent head 1dc4511. Consider uploading reports for the commit 1dc4511 to get more accurate results

@@            Coverage Diff            @@
##              main      #307   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1169      1169           
=========================================
  Hits          1169      1169           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tomvothecoder tomvothecoder merged commit 1d242e5 into main Aug 10, 2022
@tomvothecoder tomvothecoder deleted the bug/306-xesmf-dev-yml branch August 10, 2022 18:49
@tomvothecoder
Copy link
Collaborator Author

@durack1 and @pochedls, this should address the missing xesmf in your dev env now.

I tested it locally and import xcdat, no more missing module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: ModuleNotFoundError: No module named 'xesmf' - using latest main 050d57e
2 participants