Removed visibility null constraint in order to be more robust

xBimTeam · Nov 23, 2017 · 91d5b43 · 91d5b43
1 parent d52f4e7
commit 91d5b43
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/Xbim.BCF/XMLNodes/BCFComponents.cs b/Xbim.BCF/XMLNodes/BCFComponents.cs
@@ -28,17 +28,11 @@ public bool ShouldSerializeSelection()
         public BCFComponentVisibility Visibility
         {
             get { return _visibility; }
-            set
-            {
-                if (ReferenceEquals(value, null))
-                {
-                    throw new ArgumentException(this.GetType().Name + " - Visibility is mandatory");
-                }
-                else
-                {
-                    _visibility = value;
-                }
-            }
+            set { _visibility = value; }
+        }
+        public bool ShouldSerializeVisibility()
+        {
+            return Visibility != null;
         }
 
         [XmlArray(ElementName = "Coloring", Order = 4)]
@@ -79,7 +73,7 @@ public BCFComponents(XElement node, string version)
                 var selection = node.Element("Selection");
                 Selection = selection != null ? new BCFComponentSelection(selection, version) : null;
                 var visibility = node.Element("Visibility");
-                Visibility = new BCFComponentVisibility(visibility, version);
+                Visibility = visibility != null ? new BCFComponentVisibility(visibility, version) : null;
                 var coloring = node.Element("Coloring");
                 if (coloring != null)
                     Colorings = new List<BCFComponentColoringColor>(coloring.Elements("Color").Select(c => new BCFComponentColoringColor(c.Attribute("Color")?.Value)));