Skip to content
This repository has been archived by the owner on Jun 5, 2018. It is now read-only.

Creating a task that uploads all possible variants to HockeyApp #67

Merged
merged 2 commits into from
Sep 7, 2015
Merged

Creating a task that uploads all possible variants to HockeyApp #67

merged 2 commits into from
Sep 7, 2015

Conversation

jleidgens
Copy link
Contributor

  • A new task uploadToHockeyApp is defined that depends on all upload tasks
  • If no AppId is supplied for a possible variant a message is printed instead of failing the gradle run

Fixes #65

- A new task uploadToHockeyApp is defined that depends on all upload tasks
- If no AppId is supplied for a possible variant a message is printed instead of failing the gradle run
@x2on
Copy link
Owner

x2on commented Aug 27, 2015

Why shouldn't it throw a error if no appId is found?

@jleidgens
Copy link
Contributor Author

Because if the build does not fail on a missing app id the task will only upload configured variants and ignore all variants that do not have an appId.

Maybe I can change it in a way that the error is still thrown if only one variant is uploaded.

@x2on
Copy link
Owner

x2on commented Aug 27, 2015

I would suggest to throw if you upload one variant. If you run it with uploadAll I would only throw a error if no appId was matching. Make sense?

@jleidgens
Copy link
Contributor Author

Yes I will try to add this tomorrow

@x2on
Copy link
Owner

x2on commented Aug 27, 2015

Sounds great :)

@jleidgens
Copy link
Contributor Author

I implemented this. It is not the nicest way to solve this but it works.

x2on added a commit that referenced this pull request Sep 7, 2015
Creating a task that uploads all possible variants to HockeyApp
@x2on x2on merged commit 1152390 into x2on:master Sep 7, 2015
@x2on
Copy link
Owner

x2on commented Sep 7, 2015

Thanks a lot for your PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants