Improved modal detection

[harlanhaskins]

Trying to push this view controller onto a navigation stack that's already being presented causes a 'Done' button. This new method only puts on a done button if the FSImageViewerViewController is the only view controller in the navigation stack.

[x2on]

Hi @harlanhaskins,

i think this could lead to problems, if you use a a other presentation style, or?

Best,

Felix

[harlanhaskins]

Hi x2on,

I'm not sure the modalPresentationStyle will affect this...

Right now, I'm using FSImageViewerViewController inside a modal that was presented using UIModalPresentationStyleOverCurrentContext.

This only checks to make sure it's the only thing in the navigation hierarchy before presenting the 'Done' button vs. back button.

[x2on]

Wouldn't it be better to check if presentingViewController exists and the style is UIModalPresentationFullScreen or UIModalPresentationStyleOverCurrentContext and your change?

[harlanhaskins]

That's a good point -- I can make that change

[x2on]

Any news?

[harlanhaskins]

Totally forgot! I updated the PR.

[x2on]

The travis build is broken - i will have a look at it.

[harlanhaskins]

Any chance we can merge this?

[x2on]

Could you please merge current master into your branch?

[iamroberthood]

I was running across this as well. A done button would be incorrectly presented in certain circumstances. After making this change, the issue has gone away. Has this change been successfully merged into master?

[x2on]

Any news about merging?

[harlanhaskins]

Oh, my apologies. I'll do this later today!