Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartcasing #317

Merged
merged 3 commits into from
May 22, 2021
Merged

Smartcasing #317

merged 3 commits into from
May 22, 2021

Conversation

bmendric
Copy link

Closes #316

@coveralls
Copy link

Pull Request Test Coverage Report for Build 772958804

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 85.851%

Totals Coverage Status
Change from base Build 605591638: 0.07%
Covered Lines: 1080
Relevant Lines: 1258

💛 - Coveralls

@bmendric
Copy link
Author

@motemen @Songmu this is ready for review an merging.

@Songmu
Copy link
Member

Songmu commented May 16, 2021

Sorry I haven't reviewed this. I will look at it when I have some time. Please wait a little longer.

@Songmu
Copy link
Member

Songmu commented May 22, 2021

It's true that smartcasing is a behavior we see a lot, so it doesn't seem like a bad idea to incorporate it. So I'm going to merge it.
However, since it is strictly an incompatibility fix, I may revert depending on the opinions of users. Thank you very much for your cooperation.

@Songmu Songmu merged commit 22ce394 into x-motemen:master May 22, 2021
Songmu added a commit that referenced this pull request May 22, 2021
## [v1.2.0](v1.1.7...v1.2.0) (2021-05-23)

* Support AWS CodeCommit HTTP (GRC) [#321](#321) ([xeres](https://github.com/xeres))
* Smartcasing [#317](#317) ([bmendric](https://github.com/bmendric))
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 772958804

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 85.851%

Totals Coverage Status
Change from base Build 605591638: 0.07%
Covered Lines: 1080
Relevant Lines: 1258

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for case insensitive searching with list
3 participants