Use walker #195
Merged
Use walker #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I changed behavior for permission error while walking directories. saracen/walker stop walking when non-permitted directory found. If you are okay, please merge this. |
|
How about copying codes of fastwalk ? |
|
That's a good idea, but before that, we should make a suggestion to saracen/walker that it can do handle unpermitted files. Also, even if we'll use fastwalk, it's not a good idea to have source code in this repository, but it is better you fork it and utilize it in it. |
|
Before After |
Songmu
added a commit
that referenced
this pull request
Nov 4, 2019
## [v0.12.7](v0.12.6...v0.12.7) (2019-11-05) * fix accepted values of ghq.<url>.vcs in README [#196](#196) ([autopp](https://github.com/autopp)) * Use walker [#195](#195) ([mattn](https://github.com/mattn)) * Use filepath [#194](#194) ([mattn](https://github.com/mattn)) * go.{mod,sum}: Update xerrors dependency [#193](#193) ([rvolosatovs](https://github.com/rvolosatovs)) * define func detectUserName and utilize it [#191](#191) ([Songmu](https://github.com/Songmu))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filepath.Walk is bits slow since it call os.Stat for each files. This pull-request use github.com/saracen/walker instead.
Before
After