Skip to content

Commit

Permalink
Merge pull request #256 from motemen/cmdutil-stderr
Browse files Browse the repository at this point in the history
print command execution output to stderr
  • Loading branch information
Songmu authored Jan 1, 2020
2 parents c327789 + d2b62ce commit 88d14cc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 18 deletions.
14 changes: 2 additions & 12 deletions cmdutil/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
// Run the command
func Run(command string, args ...string) error {
cmd := exec.Command(command, args...)
cmd.Stdout = os.Stdout
cmd.Stdout = os.Stderr
cmd.Stderr = os.Stderr

return RunCommand(cmd, false)
Expand All @@ -31,7 +31,7 @@ func RunSilently(command string, args ...string) error {
// RunInDir runs the command in the specified directory
func RunInDir(dir, command string, args ...string) error {
cmd := exec.Command(command, args...)
cmd.Stdout = os.Stdout
cmd.Stdout = os.Stderr
cmd.Stderr = os.Stderr
cmd.Dir = dir

Expand All @@ -48,16 +48,6 @@ func RunInDirSilently(dir, command string, args ...string) error {
return RunCommand(cmd, true)
}

// RunInDirStderr run the command in the specified directory and prevent stdout output
func RunInDirStderr(dir, command string, args ...string) error {
cmd := exec.Command(command, args...)
cmd.Stdout = os.Stderr
cmd.Stderr = os.Stderr
cmd.Dir = dir

return RunCommand(cmd, true)
}

// RunFunc for the type command execution
type RunFunc func(*exec.Cmd) error

Expand Down
12 changes: 6 additions & 6 deletions vcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ var GitBackend = &VCSBackend{
return nil
},
Init: func(dir string) error {
return cmdutil.RunInDirStderr(dir, "git", "init")
return cmdutil.RunInDir(dir, "git", "init")
},
Contents: []string{".git"},
}
Expand Down Expand Up @@ -251,7 +251,7 @@ var MercurialBackend = &VCSBackend{
return runInDir(vg.silent)(vg.dir, "hg", "pull", "--update")
},
Init: func(dir string) error {
return cmdutil.RunInDirStderr(dir, "hg", "init")
return cmdutil.RunInDir(dir, "hg", "init")
},
Contents: []string{".hg"},
}
Expand Down Expand Up @@ -281,7 +281,7 @@ var DarcsBackend = &VCSBackend{
return runInDir(vg.silent)(vg.dir, "darcs", "pull")
},
Init: func(dir string) error {
return cmdutil.RunInDirStderr(dir, "darcs", "init")
return cmdutil.RunInDir(dir, "darcs", "init")
},
Contents: []string{"_darcs"},
}
Expand Down Expand Up @@ -317,10 +317,10 @@ var FossilBackend = &VCSBackend{
return runInDir(vg.silent)(vg.dir, "fossil", "update")
},
Init: func(dir string) error {
if err := cmdutil.RunInDirStderr(dir, "fossil", "init", fossilRepoName); err != nil {
if err := cmdutil.RunInDir(dir, "fossil", "init", fossilRepoName); err != nil {
return err
}
return cmdutil.RunInDirStderr(dir, "fossil", "open", fossilRepoName)
return cmdutil.RunInDir(dir, "fossil", "open", fossilRepoName)
},
Contents: []string{".fslckout", "_FOSSIL_"},
}
Expand All @@ -344,7 +344,7 @@ var BazaarBackend = &VCSBackend{
return runInDir(vg.silent)(vg.dir, "bzr", "pull", "--overwrite")
},
Init: func(dir string) error {
return cmdutil.RunInDirStderr(dir, "bzr", "init")
return cmdutil.RunInDir(dir, "bzr", "init")
},
Contents: []string{".bzr"},
}
Expand Down

0 comments on commit 88d14cc

Please sign in to comment.