Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
express.Router
, it’s possible to create self-contained routing beneath a path set in a parent router. Using an example slightly modified from the Express JS documentation:The app will now be able to handle requests to
/birds
and/birds/about
.However, while this library looks for paths that match
req.originalUrl
, it only creates next and previous paths based on the route handler. For example, given the following journey:Upon visiting
/about
, the followingpaths
object is provided:Note that
back
andnext
values don’t contain the parent path segment. Clicking on links containing those values will return the wrong (or no) page.This PR appends
req.baseUrl
which includes this information. With this fix in place, the following paths are generated:If there is no
req.baseUrl
, the previous behaviour is retained.