-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secondary navigation #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial thoughts from a quick look.
x-govuk/components/secondary-navigation/_secondary-navigation.scss
Outdated
Show resolved
Hide resolved
x-govuk/components/secondary-navigation/_secondary-navigation.scss
Outdated
Show resolved
Hide resolved
18a11e5
to
3b5a7cf
Compare
Have fixed the homepage layout, and rebased from the |
@paulrobertlloyd I've reworked the CSS on this (rather than the copy-and-paste job I had before), so now it's more similar to the primary navigation component implementation. This means the same hover and focus styles are used as primary nav - ie with the double underline on hover, and the focus highlight being smaller. We can always review this separately if thinking on this changes. This also means that the specific mobile view has been dropped, in favour of doing the same as the primary nav - ie horizontal with wrapping. Let me know what you think! |
@paulrobertlloyd I've tweaked the padding so that it's reduced on mobile, which I think helps to make it clearer which item is the current page? In reality, I think for most services, the nav should fix on a single line for most mobile viewports (given how much wider phones are nowadays). We could still consider an option to have the items stack vertically on mobile (with or without a toggle) - but I think if we do that, it's worth doing it for the primary nav and secondary nav at the same time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s leave thoughts of responsive versions of this for now; as you say, in most cases shouldn’t be needed and the items wrap much better now.
Also… do you think an example layout for the Prototype Kit would be a useful addition?
3300386
to
134d130
Compare
134d130
to
c042f3d
Compare
This adds a secondary navigation component, plus some documentation about it.
Resolves #182