Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow govukButton to be decorated #4

Closed
paulrobertlloyd opened this issue Mar 22, 2022 · 2 comments · Fixed by #35
Closed

Allow govukButton to be decorated #4

paulrobertlloyd opened this issue Mar 22, 2022 · 2 comments · Fixed by #35
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0

Comments

@paulrobertlloyd
Copy link
Contributor

button elements can take id, name and value attributes, too.
@paulrobertlloyd paulrobertlloyd added enhancement New feature or request good first issue Good for newcomers labels Mar 22, 2022
@paulrobertlloyd paulrobertlloyd added this to the v1.0.0 milestone Jun 21, 2022
@fofr
Copy link
Member

fofr commented Jun 23, 2022

Have you needed to do this?

@paulrobertlloyd
Copy link
Contributor Author

Yup, shortly before I added this issue. I often use button values to change the status of a thing from draft to published, for example. Saves either creating a separate hidden input or updating the data in the POST route.

paulrobertlloyd added a commit that referenced this issue Jun 24, 2022
@paulrobertlloyd
Allow button component (not links) to be decorated. Fixes #4
6cee38b
@paulrobertlloyd paulrobertlloyd mentioned this issue Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Allow button component (not linked) to be decorated x-govuk/govuk-prototype-components
2 participants
@fofr @paulrobertlloyd