Add config to prevent automatic boldening of radio button labels in a collection #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for govuk-form-builder processing.
|
peteryates
force-pushed
the
allow-auto-boldening-of-radio-buttons-in-collection-to-be-disabled
branch
from
cd6773d to
44bd340
Compare
The original behaviour of the form builder followed the examples in the Design System documentation at the time and emboldened any radio button labels when hints were present. These examples were dropped in 2020[0] and the guidance changed. In the referenced PR I said I'd look into changing the behaviour in the form builder but never did. As it would be a breaking change we're just adding a new configuration option, `default_collection_radio_buttons_auto_bold_labels`, to allow the behaviour to be modified. [0] alphagov/govuk-design-system#1284
peteryates
force-pushed
the
allow-auto-boldening-of-radio-buttons-in-collection-to-be-disabled
branch
from
44bd340 to
42dec38
Compare
peteryates
deleted the
allow-auto-boldening-of-radio-buttons-in-collection-to-be-disabled
branch
|
Brilliant, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original behaviour of the form builder followed the examples in the Design System documentation at the time and emboldened any radio button labels when hints were present.
These examples were dropped in 2020 and the guidance changed. In the referenced PR I said I'd look into changing the behaviour in the form builder but never did.
Modifying the default would be a breaking change so we're just adding a new configuration option,
default_collection_radio_buttons_auto_bold_labels, for the time being. The default will remaintruefor the time being but may change at the next major release.To disable the automatic emboldening behaviour add this line to your configuration:
Fixes #373