-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSN-59] - Created EventsController #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the logic on the controllers' side, custom exceptions and a library for validation were added. The implemented handlers are allow to catch those exceptions and return the corresponding statuses and detailed response. Additionally, mappers have been created to more easily convert entities into the corresponding DTOs, fixed enum conversion when it comes to UserRole and export postgres port on the development environment.
@bilimig rebase and add labels |
wzarek
changed the title
[RSN-59] Created EventsController
[RSN-59] - Created EventsController
Jun 20, 2024
bilimig
added
scope: backend
Indicates that PR relates to backend changes.
status: ready for review
Determines that PR is ready for review.
labels
Jun 20, 2024
wzarek
added
status: require changes
Determines that PR requires changes to be approved.
status: ready for review
Determines that PR is ready for review.
and removed
status: ready for review
Determines that PR is ready for review.
status: require changes
Determines that PR requires changes to be approved.
labels
Jun 22, 2024
bilimig
added
status: require changes
Determines that PR requires changes to be approved.
and removed
status: ready for review
Determines that PR is ready for review.
labels
Jun 22, 2024
wzarek
added
status: ready for review
Determines that PR is ready for review.
and removed
status: require changes
Determines that PR requires changes to be approved.
labels
Jun 22, 2024
changed removing tags and params that are not attached to any event, thay will be hold in database
wzarek
added
status: ready for review
Determines that PR is ready for review.
and removed
status: require changes
Determines that PR requires changes to be approved.
labels
Jun 22, 2024
bilimig
added
status: ready for review
Determines that PR is ready for review.
and removed
status: ready for review
Determines that PR is ready for review.
labels
Jun 22, 2024
added returnign empty list if image for event is not found, filtered get all events to not return waiting for aproval events
it wont return events where status is receted canceled and panding aproval
wzarek
requested changes
Jun 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also check warnings
wzarek
added
status: require changes
Determines that PR requires changes to be approved.
and removed
status: ready for review
Determines that PR is ready for review.
labels
Jun 23, 2024
wzarek
added
status: ready for review
Determines that PR is ready for review.
and removed
status: require changes
Determines that PR requires changes to be approved.
labels
Jun 23, 2024
wzarek
requested changes
Jun 23, 2024
raczu
approved these changes
Jun 23, 2024
bilimig
added a commit
that referenced
this pull request
Jun 23, 2024
* test: add unit tests for jwt, handlers and validators * feat: add placeholders for endpoints * chore: add missing controllers placeholders * Restored GetCurrentUser method * [RSN-60] - Implement required methods in MeController and UserController (#58) * feat: add jwt and exceptions handlers Simplify the logic on the controllers' side, custom exceptions and a library for validation were added. The implemented handlers are allow to catch those exceptions and return the corresponding statuses and detailed response. Additionally, mappers have been created to more easily convert entities into the corresponding DTOs, fixed enum conversion when it comes to UserRole and export postgres port on the development environment. * test: add unit tests for jwt, handlers and validators * feat: add placeholders for endpoints * chore: add missing controllers placeholders * Created controllers * Created controllers * Finished controllers and updated services * Update UserService tests * Create and update image methods update * Image controllers update * Update controller and service * Added Address to UserDto * Controller update and service changes Changed Image and Participant service (and participant tests), controller now use new service methods * Methods name changes --------- Co-authored-by: raczu <[email protected]> * [RSN-59] - Created EventsController (#59) * feat: add jwt and exceptions handlers Simplify the logic on the controllers' side, custom exceptions and a library for validation were added. The implemented handlers are allow to catch those exceptions and return the corresponding statuses and detailed response. Additionally, mappers have been created to more easily convert entities into the corresponding DTOs, fixed enum conversion when it comes to UserRole and export postgres port on the development environment. * test: add unit tests for jwt, handlers and validators * feat: add placeholders for endpoints * chore: add missing controllers placeholders * Created EventsController * Little Updates * Updated controllers * Update adding and updating image in eventController * Updated eventcontroller logic * Updated EventsController * Fixed build issues * updated eventscontroller * fixed build issue addedscope for address service * Update EventServicesTest.cs * Update EventsController.cs * syntax update * updated models changed removing tags and params that are not attached to any event, thay will be hold in database * Update EventServicesTest.cs * Updated EventController * updated events controller added returnign empty list if image for event is not found, filtered get all events to not return waiting for aproval events * updated logic in getallaevenst it wont return events where status is receted canceled and panding aproval * fixes and updates * Fixes and cleanup after rebase and confilts * Update EventService.cs * updates * Updated logic with slag on creation * Update EventValidatorTests.cs * Update EventValidatorTests.cs --------- Co-authored-by: raczu <[email protected]> * Controller and service update Return user's image for comment --------- Co-authored-by: raczu <[email protected]> Co-authored-by: Maciej Koperdowski <[email protected]> Co-authored-by: Maciej Koperdowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: backend
Indicates that PR relates to backend changes.
status: ready for review
Determines that PR is ready for review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created EventsControllers
Related issue and/or ticket
RSN-59