Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSN-67] Add more event statuses and fix some errors #53
[RSN-67] Add more event statuses and fix some errors #53
Changes from all commits
4352132
5e68f3a
f732b6c
7a5bf14
06a5eae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 285 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (ubuntu-latest)
Check warning on line 285 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (ubuntu-latest)
Check warning on line 285 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (macos-latest)
Check warning on line 285 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (macos-latest)
Check warning on line 285 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (windows-latest)
Check warning on line 285 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (windows-latest)
Check warning on line 288 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (ubuntu-latest)
Check warning on line 288 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (ubuntu-latest)
Check warning on line 288 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (macos-latest)
Check warning on line 288 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (macos-latest)
Check warning on line 288 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (windows-latest)
Check warning on line 288 in Server/ReasnAPI/ReasnAPI/Models/Database/ReasnContext.cs
GitHub Actions / dotnet-tests (windows-latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context: we can use null propagation to check for nulls, for empty ones I think we don't care really, propably it will be handled on FE anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you really want to check it for being empty then alright, let's go with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned out that not existing fields are set to null by default, however if their value will be set to empty string this violates database and causing exception