Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSN-26] Change regexes to match more correct formats #45

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

raczu
Copy link
Collaborator

@raczu raczu commented Jun 3, 2024

Description

Change regexes to match more correct formats - applies to address.street, address.city, address.country, user.name, user.surname and user.username.

Following screenshots confirming fixes:
address.country

image

address.street

image

address.city

image

user.name

image

user.surname

image

user.username

image

Related issue and/or ticket

Closes #26 RSN-26

@raczu raczu added scope: database Indicates that PR relates to database changes. type: fix PR's categorised as fix (for issues). status: ready for review Determines that PR is ready for review. labels Jun 3, 2024
@raczu raczu requested a review from mkoper02 June 3, 2024 12:52
@raczu raczu marked this pull request as ready for review June 3, 2024 13:39
@raczu
Copy link
Collaborator Author

raczu commented Jun 3, 2024

@mkoper02

@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. status: ready for review Determines that PR is ready for review. and removed status: ready for review Determines that PR is ready for review. status: require changes Determines that PR requires changes to be approved. labels Jun 3, 2024
@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels Jun 3, 2024
@wzarek wzarek added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels Jun 3, 2024
Copy link
Collaborator

@mkoper02 mkoper02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@raczu raczu merged commit a3babe3 into main Jun 3, 2024
7 checks passed
@wzarek wzarek deleted the RSN-26 branch June 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: database Indicates that PR relates to database changes. status: ready for review Determines that PR is ready for review. type: fix PR's categorised as fix (for issues).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Regex problem with Address and User tables
3 participants